refactor: Clean up deprecated rclone_config import references

Updated bisync_commands.py and core_commands.py to use simplified
configure_rclone_remote() function instead of deprecated
add_tenant_to_rclone_config(). Removed MOUNT_PROFILES import and
replaced dynamic help text with static string.

mount_commands.py still has errors but will be removed entirely in Phase 5.

Related to SPEC-20 Phase 2 cleanup.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>
This commit is contained in:
phernandez
2025-10-28 11:25:38 -05:00
parent 0887ad4f8a
commit 685cccf708
3 changed files with 5 additions and 8 deletions
@@ -17,7 +17,7 @@ from basic_memory.cli.commands.cloud.cloud_utils import (
fetch_cloud_projects,
)
from basic_memory.cli.commands.cloud.rclone_config import (
add_tenant_to_rclone_config,
configure_rclone_remote,
)
from basic_memory.cli.commands.cloud.rclone_installer import RcloneInstallError, install_rclone
from basic_memory.config import ConfigManager
@@ -343,9 +343,7 @@ def setup_cloud_bisync(sync_dir: Optional[str] = None) -> None:
# Step 4: Configure rclone
console.print("\n[blue]Step 4: Configuring rclone...[/blue]")
add_tenant_to_rclone_config(
tenant_id=tenant_id,
bucket_name=bucket_name,
configure_rclone_remote(
access_key=access_key,
secret_key=secret_key,
)
@@ -27,9 +27,8 @@ from basic_memory.cli.commands.cloud.bisync_commands import (
run_check,
setup_cloud_bisync,
show_bisync_status,
BISYNC_PROFILES,
)
from basic_memory.cli.commands.cloud.rclone_config import MOUNT_PROFILES
from basic_memory.cli.commands.cloud.bisync_commands import BISYNC_PROFILES
console = Console()
@@ -192,7 +191,7 @@ def setup(
@cloud_app.command("mount")
def mount(
profile: str = typer.Option(
"balanced", help=f"Mount profile: {', '.join(MOUNT_PROFILES.keys())}"
"balanced", help="Mount profile: balanced, safe, or fast"
),
path: Optional[str] = typer.Option(
None, help="Custom mount path (default: ~/basic-memory-{tenant-id})"
+1 -1
View File
@@ -116,4 +116,4 @@ def test_load_rclone_config_nonexistent(temp_rclone_config):
# Should return empty config without error
config = load_rclone_config()
assert len(config.sections()) == 0
assert len(config.sections()) == 0