admin/basicmachines-co-basic-memory
1
0
Fork 0
mirror of https://github.com/basicmachines-co/basic-memory synced 2026-06-21 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): allow ci PR title scope

Browse Source 
Allows ci as a semantic PR title scope and covers the workflow config with a regression test.
This commit is contained in:
Paul Hernandez
2026-06-04 21:05:29 -05:00
committed by GitHub
parent 2de8183e85
commit a6cfed96f1
3 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/pr-title.yml
+1
View File
@@ -38,6 +38,7 @@ jobs:
mcp
sync
ui
ci
deps
installer
plugins
AGENTS.md
+2 -2
View File
@@ -83,7 +83,7 @@ Before opening or updating a PR, run the checks that mirror the common required
- Run `just typecheck` in addition to targeted `ruff` and `pytest` commands when tests were added or changed.
- Sign commits with `git commit -s` so DCO passes. If a PR branch already has unsigned commits, rewrite the branch with signed-off commits before asking for review.
- Use a semantic PR title accepted by `.github/workflows/pr-title.yml`: `type(scope): summary`.
- Use one of the allowed scopes: `core`, `cli`, `api`, `mcp`, `sync`, `ui`, `deps`, `installer`, `plugins`, `skills`, `integrations`.
- Use one of the allowed scopes: `core`, `cli`, `api`, `mcp`, `sync`, `ui`, `ci`, `deps`, `installer`, `plugins`, `skills`, `integrations`.
### Test Structure
@@ -506,7 +506,7 @@ With GitHub integration, the development workflow includes:
5. **Code Commits**: ALWAYS sign off commits with `git commit -s`
6. **Pull Request Titles**: PR titles must follow the semantic format enforced by `.github/workflows/pr-title.yml`: `type(scope): summary`
- Allowed types: `feat`, `fix`, `chore`, `docs`, `style`, `refactor`, `perf`, `test`, `build`, `ci`
- Allowed scopes: `core`, `cli`, `api`, `mcp`, `sync`, `ui`, `deps`, `installer`, `plugins`, `skills`, `integrations`
- Allowed scopes: `core`, `cli`, `api`, `mcp`, `sync`, `ui`, `ci`, `deps`, `installer`, `plugins`, `skills`, `integrations`
- Example: `fix(cli): propagate cloud workspace routing`
This level of integration represents a new paradigm in AI-human collaboration, where the AI assistant becomes a full-fledged team member rather than just a tool for generating code snippets.
tests/test_pr_title_workflow.py
+18
View File
@@ -0,0 +1,18 @@
from pathlib import Path
import yaml
def _semantic_pr_action_inputs() -> dict:
workflow = yaml.safe_load(Path(".github/workflows/pr-title.yml").read_text(encoding="utf-8"))
steps = workflow["jobs"]["main"]["steps"]
action_step = next(
step for step in steps if step.get("uses") == "amannn/action-semantic-pull-request@v6"
)
return action_step["with"]
def test_pr_title_workflow_allows_ci_scope() -> None:
scopes = _semantic_pr_action_inputs()["scopes"].split()
assert "ci" in scopes