admin/basicmachines-co-basic-memory
1
0
Fork 0
mirror of https://github.com/basicmachines-co/basic-memory synced 2026-06-21 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): anchor paged-status test fake on the &page separator

Browse Source 
'page=1' substring-matched 'per_page=100', so the fake served page 1
forever and the pagination loop hung — caught by the new 120s test
timeout on every CI leg.

Signed-off-by: phernandez <paul@basicmachines.co>
This commit is contained in:
phernandez
2026-06-10 11:12:53 -05:00
parent 8668118f78
commit afa694ba8d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/scripts/test_bm_bossbot_status.py
+5 -3
View File
@@ -321,8 +321,10 @@ def test_head_sha_was_approved_matches_only_the_approval_record(
def _paged(pages: list[list[dict]]):
def fake(*, method: str, path: str, token: str, payload=None):
# Anchor on "&page=N" — a bare "page=N" substring also matches
# "per_page=100", which served page 1 forever and hung the loop.
for number, page in enumerate(pages, start=1):
if f"page={number}" in path:
if f"&page={number}" in path:
return page
return []
@@ -363,9 +365,9 @@ def test_head_sha_was_approved_pages_past_first_page_of_statuses(
def fake(*, method: str, path: str, token: str, payload=None):
pages_served.append(path)
if "page=1" in path:
if "&page=1" in path:
return [failure] * 100
if "page=2" in path:
if "&page=2" in path:
return [approval]
return []