mirror of
https://github.com/basicmachines-co/basic-memory
synced 2026-06-21 13:47:35 +00:00
24abf11dab
Two BM Bossbot fixes: 1. Unresolved review threads now block approval. The review prompt only sees metadata+diff, so an approve verdict said nothing about outstanding feedback — #932 merged with two open Codex P2 threads. finalize now counts unresolved reviewThreads via GraphQL and fails the status when any remain. A new recheck command, triggered by pull_request_review / review_comment / review_thread events, flips the status to failure when feedback arrives after approval and restores a previously earned approval for the same head SHA once every thread is resolved. Review and recheck jobs use separate job-level concurrency groups so neither cancels the other. 2. PR images depict the PR's content, not the review outcome. The image prompt previously used the BM Bossbot review summary (verdict/status) as its only source material, so every image rendered an APPROVED stamp. The prompt now sources the PR title and the author's own description (managed bot blocks stripped) and explicitly bans approval stamps, verdict wording, badges, checkmarks, and Bossbot branding. Theme selection seeds on PR number+title for stability across re-reviews. Signed-off-by: phernandez <paul@basicmachines.co>
Dual-Backend Testing
Basic Memory tests run against both SQLite and Postgres backends to ensure compatibility.
Quick Start
# Run tests against SQLite only (default, no setup needed)
pytest
# Run tests against Postgres only (requires docker-compose)
docker-compose -f docker-compose-postgres.yml up -d
BASIC_MEMORY_TEST_POSTGRES=1 \
POSTGRES_TEST_URL=postgresql+asyncpg://basic_memory_user:dev_password@localhost:5433/basic_memory \
pytest -m postgres
# Run tests against BOTH backends
docker-compose -f docker-compose-postgres.yml up -d
pytest --run-all-backends # Not yet implemented - run both commands above
How It Works
Parametrized Backend Fixture
The db_backend fixture is parametrized to run tests against both sqlite and postgres:
@pytest.fixture(
params=[
pytest.param("sqlite", id="sqlite"),
pytest.param("postgres", id="postgres", marks=pytest.mark.postgres),
]
)
def db_backend(request) -> Literal["sqlite", "postgres"]:
return request.param
Backend-Specific Engine Factories
Each backend has its own engine factory implementation:
sqlite_engine_factory- Uses in-memory SQLite (fast, isolated)postgres_engine_factory- Uses Postgres test database (realistic, requires Docker)
The main engine_factory fixture delegates to the appropriate implementation based on db_backend.
Configuration
The app_config fixture automatically configures the correct backend:
# SQLite config
database_backend = DatabaseBackend.SQLITE
database_url = None # Uses default SQLite path
# Postgres config
database_backend = DatabaseBackend.POSTGRES
database_url = "postgresql+asyncpg://basic_memory_user:dev_password@localhost:5433/basic_memory"
Running Postgres Tests
1. Start Postgres Docker Container
docker-compose -f docker-compose-postgres.yml up -d
This starts:
- Postgres 17 with pgvector (
pgvector/pgvector:pg17) on port 5433 (not 5432 to avoid conflicts) - Database:
basic_memory - Credentials:
basic_memory_user/dev_password
2. Run Postgres Tests
# Run only Postgres tests
BASIC_MEMORY_TEST_POSTGRES=1 \
POSTGRES_TEST_URL=postgresql+asyncpg://basic_memory_user:dev_password@localhost:5433/basic_memory \
pytest -m postgres
# Run specific test with Postgres
BASIC_MEMORY_TEST_POSTGRES=1 \
POSTGRES_TEST_URL=postgresql+asyncpg://basic_memory_user:dev_password@localhost:5433/basic_memory \
pytest tests/repository/test_entity_repository.py::test_create -m postgres
# Skip Postgres tests (default behavior)
pytest -m "not postgres"
3. Stop Docker Container
docker-compose -f docker-compose-postgres.yml down
Test Isolation
SQLite Tests
- Each test gets a fresh in-memory database
- Automatic cleanup (database destroyed after test)
- No setup required
Postgres Tests
- Database is cleaned before each test (drop all tables, recreate)
- Tests share the same Postgres instance but get isolated schemas
- Requires Docker Compose to be running
Markers
postgres- Marks tests that run against Postgres backend- Use
-m postgresto run only Postgres tests - Use
-m "not postgres"to skip Postgres tests (default)
CI Integration
GitHub Actions
Use service containers for Postgres (no Docker Compose needed):
jobs:
test:
runs-on: ubuntu-latest
# Postgres service container
services:
postgres:
image: pgvector/pgvector:pg17
env:
POSTGRES_DB: basic_memory_test
POSTGRES_USER: basic_memory_user
POSTGRES_PASSWORD: dev_password
ports:
- 5433:5432
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- name: Run SQLite tests
run: pytest -m "not postgres"
- name: Run Postgres tests
run: pytest -m postgres
Troubleshooting
Postgres tests fail with "connection refused"
Make sure Docker Compose is running:
docker-compose -f docker-compose-postgres.yml ps
docker-compose -f docker-compose-postgres.yml logs postgres
Port 5433 already in use
Either:
- Stop the conflicting service
- Change the port in
docker-compose-postgres.ymlandtests/conftest.py
Tests hang or timeout
Check Postgres health:
docker-compose -f docker-compose-postgres.yml exec postgres pg_isready -U basic_memory_user
Future Enhancements
- Add
--run-all-backendsCLI flag to run both backends in sequence - Implement test fixtures for backend-specific features (e.g., Postgres full-text search vs SQLite FTS5)
- Add performance comparison benchmarks between backends