Release 2019.11.1

RELEASE_NOTES

@@ -1,7 +1,3 @@
-2019.11.2
-- 2019-11-18 TUN-2567: AuthOutcome can be turned back into AuthResponse
-- 2019-11-18 TUN-2563: Exposes config_version metrics
-
 2019.11.1
 - 2019-11-12 Add db-connect, a SQL over HTTPS server
 - 2019-11-12 TUN-2053: Add a /healthcheck endpoint to the metrics server

supervisor/supervisor.go

@@ -16,7 +16,6 @@ import (
 	"github.com/cloudflare/cloudflared/h2mux"
 	"github.com/cloudflare/cloudflared/streamhandler"
 	"github.com/cloudflare/cloudflared/tunnelrpc/pogs"
-	"github.com/prometheus/client_golang/prometheus"
 	"github.com/sirupsen/logrus"
 )
 
@@ -29,27 +28,6 @@ type Supervisor struct {
 	useConfigResultChan chan<- *pogs.UseConfigurationResult
 	state               *state
 	logger              *logrus.Entry
-	metrics             metrics
-}
-
-type metrics struct {
-	configVersion prometheus.Gauge
-}
-
-func newMetrics() metrics {
-	configVersion := prometheus.NewGauge(prometheus.GaugeOpts{
-		Namespace: "supervisor",
-		Subsystem: "supervisor",
-		Name:      "config_version",
-		Help:      "Latest configuration version received from Cloudflare",
-	},
-	)
-	prometheus.MustRegister(
-		configVersion,
-	)
-	return metrics{
-		configVersion: configVersion,
-	}
 }
 
 func NewSupervisor(
@@ -92,7 +70,6 @@ func NewSupervisor(
 		useConfigResultChan: useConfigResultChan,
 		state:               newState(defaultClientConfig),
 		logger:              logger.WithField("subsystem", "supervisor"),
-		metrics:             newMetrics(),
 	}, nil
 }
 
@@ -154,7 +131,6 @@ func (s *Supervisor) notifySubsystemsNewConfig(newConfig *pogs.ClientConfig) *po
 			Success: true,
 		}
 	}
-	s.metrics.configVersion.Set(float64(newConfig.Version))
 
 	s.state.updateConfig(newConfig)
 	var tunnelHostnames []h2mux.TunnelHostname

tunnelrpc/pogs/auth_outcome.go

@@ -43,8 +43,6 @@ func (ar AuthenticateResponse) Outcome() AuthOutcome {
 //go-sumtype:decl AuthOutcome
 type AuthOutcome interface {
 	isAuthOutcome()
-	// Serialize into an AuthenticateResponse which can be sent via Capnp
-	Serialize() AuthenticateResponse
 }
 
 // AuthSuccess means the backend successfully authenticated this cloudflared.
@@ -58,14 +56,6 @@ func (ao *AuthSuccess) RefreshAfter() time.Duration {
 	return hoursToTime(ao.HoursUntilRefresh)
 }
 
-// Serialize into an AuthenticateResponse which can be sent via Capnp
-func (ao *AuthSuccess) Serialize() AuthenticateResponse {
-	return AuthenticateResponse{
-		Jwt:               ao.Jwt,
-		HoursUntilRefresh: ao.HoursUntilRefresh,
-	}
-}
-
 func (ao *AuthSuccess) isAuthOutcome() {}
 
 // AuthFail means this cloudflared has the wrong auth and should exit.
@@ -73,13 +63,6 @@ type AuthFail struct {
 	Err error
 }
 
-// Serialize into an AuthenticateResponse which can be sent via Capnp
-func (ao *AuthFail) Serialize() AuthenticateResponse {
-	return AuthenticateResponse{
-		PermanentErr: ao.Err.Error(),
-	}
-}
-
 func (ao *AuthFail) isAuthOutcome() {}
 
 // AuthUnknown means the backend couldn't finish checking authentication. Try again later.
@@ -93,14 +76,6 @@ func (ao *AuthUnknown) RefreshAfter() time.Duration {
 	return hoursToTime(ao.HoursUntilRefresh)
 }
 
-// Serialize into an AuthenticateResponse which can be sent via Capnp
-func (ao *AuthUnknown) Serialize() AuthenticateResponse {
-	return AuthenticateResponse{
-		RetryableErr:      ao.Err.Error(),
-		HoursUntilRefresh: ao.HoursUntilRefresh,
-	}
-}
-
 func (ao *AuthUnknown) isAuthOutcome() {}
 
 func hoursToTime(hours uint8) time.Duration {

tunnelrpc/pogs/auth_test.go

@@ -58,13 +58,9 @@ func TestAuthenticateResponseOutcome(t *testing.T) {
 				Jwt:               tt.fields.Jwt,
 				HoursUntilRefresh: tt.fields.HoursUntilRefresh,
 			}
-			got := ar.Outcome()
-			if !reflect.DeepEqual(got, tt.want) {
+			if got := ar.Outcome(); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("AuthenticateResponse.Outcome() = %T, want %v", got, tt.want)
 			}
-			if got != nil && !reflect.DeepEqual(got.Serialize(), ar) {
-				t.Errorf(".Outcome() and .Serialize() should be inverses but weren't. Expected %v, got %v", ar, got.Serialize())
-			}
 		})
 	}
 }