admin/javascript-obfuscator-javascript-obfuscator
1
0
Fork 0
mirror of https://github.com/javascript-obfuscator/javascript-obfuscator synced 2026-08-09 12:42:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize scope identifiers transformer performance (#1417)

Browse Source
This commit is contained in:
Filip Sobol
2026-07-09 09:30:31 +04:00
committed by GitHub
parent 7035494943
commit 8be923d41b
1 changed files with 29 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/node-transformers/rename-identifiers-transformers/ScopeIdentifiersTransformer.ts
+29 -39
View File
@@ -32,9 +32,9 @@ export class ScopeIdentifiersTransformer extends AbstractNodeTransformer {
private readonly identifierReplacer: IIdentifierReplacer;
/**
* @type {WeakMap<TNodeWithLexicalScope, boolean>}
* @type {WeakMap<TNodeWithLexicalScope, Set<string> | false>}
*/
private readonly lexicalScopesWithObjectPatternWithoutDeclarationMap: WeakMap<TNodeWithLexicalScope, boolean> =
private readonly lexicalScopesWithObjectPatternWithoutDeclarationMap: WeakMap<TNodeWithLexicalScope, Set<string> | false> =
new WeakMap();
/**
@@ -336,14 +336,6 @@ export class ScopeIdentifiersTransformer extends AbstractNodeTransformer {
identifierNode: ESTree.Identifier,
lexicalScopeNode: TNodeWithLexicalScope
): boolean {
let isLexicalScopeHasObjectPatternWithoutDeclaration: boolean | undefined =
this.lexicalScopesWithObjectPatternWithoutDeclarationMap.get(lexicalScopeNode);
// lexical scope was traversed before and object pattern without declaration was not found
if (isLexicalScopeHasObjectPatternWithoutDeclaration === false) {
return false;
}
const hasVarDefinitions: boolean = variable.defs.some(
(definition: eslintScope.Definition) => (<any>definition).kind === 'var'
);
@@ -352,42 +344,40 @@ export class ScopeIdentifiersTransformer extends AbstractNodeTransformer {
return false;
}
let isProhibitedVariableDeclaration: boolean = false;
let prohibitedVariableNames: Set<string> | false | undefined =
this.lexicalScopesWithObjectPatternWithoutDeclarationMap.get(lexicalScopeNode);
estraverse.traverse(lexicalScopeNode, {
enter: (node: ESTree.Node, parentNode: ESTree.Node | null): void | estraverse.VisitorOption => {
if (
NodeGuards.isObjectPatternNode(node) &&
parentNode &&
NodeGuards.isAssignmentExpressionNode(parentNode)
) {
isLexicalScopeHasObjectPatternWithoutDeclaration = true;
if (prohibitedVariableNames === undefined) {
const foundVariableNames: Set<string> = new Set();
const properties: (ESTree.Property | ESTree.RestElement)[] = node.properties;
estraverse.traverse(lexicalScopeNode, {
enter: (node: ESTree.Node, parentNode: ESTree.Node | null): void => {
if (
NodeGuards.isObjectPatternNode(node) &&
parentNode &&
NodeGuards.isAssignmentExpressionNode(parentNode)
) {
const properties: (ESTree.Property | ESTree.RestElement)[] = node.properties;
for (const property of properties) {
isProhibitedVariableDeclaration =
NodeGuards.isPropertyNode(property) &&
!property.computed &&
property.shorthand &&
NodeGuards.isIdentifierNode(property.key) &&
identifierNode.name === property.key.name;
if (!isProhibitedVariableDeclaration) {
continue;
for (const property of properties) {
if (
NodeGuards.isPropertyNode(property) &&
!property.computed &&
property.shorthand &&
NodeGuards.isIdentifierNode(property.key)
) {
foundVariableNames.add(property.key.name);
}
}
return estraverse.VisitorOption.Break;
}
}
}
});
});
this.lexicalScopesWithObjectPatternWithoutDeclarationMap.set(
lexicalScopeNode,
isLexicalScopeHasObjectPatternWithoutDeclaration ?? false
);
prohibitedVariableNames = foundVariableNames.size ? foundVariableNames : false;
return isProhibitedVariableDeclaration;
this.lexicalScopesWithObjectPatternWithoutDeclarationMap.set(lexicalScopeNode, prohibitedVariableNames);
}
return prohibitedVariableNames !== false && prohibitedVariableNames.has(identifierNode.name);
}
}