admin/lifting-bits-remill
1
0
Fork 0
mirror of https://github.com/lifting-bits/remill synced 2026-06-21 13:56:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not propagate empty CMAKE_MSVC_RUNTIME_LIBRARY

Browse Source
This commit is contained in:
Duncan Ogilvie
2026-04-20 14:27:41 +02:00
committed by Kyle Elliott
parent 71b1915a7e
commit 0e324aee8c
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dependencies/superbuild.cmake
Vendored
+10 -1
View File
@@ -124,10 +124,19 @@ list(APPEND CMAKE_ARGS
"-DCMAKE_POSITION_INDEPENDENT_CODE:STRING=ON"
"-DCMAKE_ERROR_DEPRECATED:STRING=OFF"
"-DCMAKE_ERROR_DEVELOPER_WARNINGS:STRING=OFF"
"-DCMAKE_MSVC_RUNTIME_LIBRARY:STRING=${CMAKE_MSVC_RUNTIME_LIBRARY}"
"-DCMAKE_POLICY_DEFAULT_CMP0091:STRING=NEW" # Needed to make sure gflags respects CMAKE_MSVC_RUNTIME_LIBRARY as their minimum CMake version is older than 3.15.
)
# Only propagate the MSVC runtime selection if the parent project explicitly set
# one. Passing an empty CMAKE_MSVC_RUNTIME_LIBRARY to external projects on
# Windows suppresses the CRT selection and breaks clang's compiler checks.
if(DEFINED CMAKE_MSVC_RUNTIME_LIBRARY
AND NOT CMAKE_MSVC_RUNTIME_LIBRARY STREQUAL "")
list(APPEND CMAKE_ARGS
"-DCMAKE_MSVC_RUNTIME_LIBRARY:STRING=${CMAKE_MSVC_RUNTIME_LIBRARY}"
)
endif()
if(CMAKE_VERSION VERSION_GREATER_EQUAL "4.0")
list(APPEND CMAKE_ARGS
"-DCMAKE_POLICY_VERSION_MINIMUM:STRING=${CMAKE_MINIMUM_REQUIRED_VERSION}"