changed ExitStatus to 1 when terminating processes

git-svn-id: svn://svn.code.sf.net/p/processhacker/code@4155 21ef857c-d57f-4fe0-8362-d861dc6d29cd

2.x/trunk/CHANGELOG.txt

@@ -6,6 +6,7 @@ Process Hacker
      for processes
    * Command line support for setting process priority and 
      I/O priority
+   * Improved termination of explorer.exe
  * FIXED:
    * Icon should restore the main window if it is minimized
    * System Information window crashes

2.x/trunk/ProcessHacker/actions.c

@@ -820,7 +820,11 @@ BOOLEAN PhUiTerminateProcesses(
             Processes[i]->ProcessId
             )))
         {
-            status = PhTerminateProcess(processHandle, STATUS_SUCCESS);
+            // An exit status of 1 is used here for compatibility reasons:
+            // 1. Both Task Manager and Process Explorer use 1.
+            // 2. winlogon tries to restart explorer.exe if the exit status is not 1.
+
+            status = PhTerminateProcess(processHandle, 1);
             NtClose(processHandle);
         }
 

2.x/trunk/ProcessHacker/phsvc/svcapi.c

@@ -223,7 +223,7 @@ NTSTATUS PhSvcApiControlProcess(
     case PhSvcControlProcessTerminate:
         if (NT_SUCCESS(status = PhOpenProcess(&processHandle, PROCESS_TERMINATE, processId)))
         {
-            status = PhTerminateProcess(processHandle, STATUS_SUCCESS);
+            status = PhTerminateProcess(processHandle, 1); // see notes in PhUiTerminateProcesses
             NtClose(processHandle);
         }
         break;