admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

backtrace.c (packed_backtrace): avoid calling each_backtrace() twice

Browse Source 
Since the length of the backtrace is at most `ciidx + 1` we can avoid
the first call of each_backtrace().
This commit is contained in:
Yukihiro "Matz" Matsumoto
2024-02-07 17:32:58 +09:00
parent b67cea4442
commit 0a11215452
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backtrace.c
+7 -12
View File
@@ -106,19 +106,14 @@ packed_backtrace(mrb_state *mrb)
if (ciidx >= mrb->c->ciend - mrb->c->cibase)
ciidx = mrb->c->ciend - mrb->c->cibase; /* ciidx is broken... */
/* count the number of backtraces */
int len = each_backtrace(mrb, ciidx, NULL, NULL);
ptrdiff_t len = ciidx + 1;
backtrace = MRB_OBJ_ALLOC(mrb, MRB_TT_BACKTRACE, NULL);
if (len > 0) {
void *ptr = mrb_malloc(mrb, len * sizeof(struct mrb_backtrace_location));
backtrace->locations = (struct mrb_backtrace_location*)ptr;
backtrace->len = len;
each_backtrace(mrb, ciidx, pack_backtrace_i, &ptr);
}
else {
backtrace->locations = NULL;
backtrace->len = 0;
}
void *ptr = mrb_malloc(mrb, len * sizeof(struct mrb_backtrace_location));
backtrace->locations = (struct mrb_backtrace_location*)ptr;
backtrace->len = each_backtrace(mrb, ciidx, pack_backtrace_i, &ptr);
return (struct RObject*)backtrace;
}