admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mirb_buffer.c: extract buffer_ensure_line_cap() helper

Browse Source 
Replace three identical 7-line blocks that grow the lines array
with a single buffer_ensure_line_cap() helper function, matching
the existing line_ensure_cap() naming pattern.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2026-02-23 14:05:38 +09:00
parent c23536daf9
commit 0b07cc1381
1 changed files with 19 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bin-mirb/tools/mirb/mirb_buffer.c
+19 -24
View File
@@ -256,6 +256,22 @@ line_set(mirb_line *line, const char *str, size_t len)
return TRUE;
}
/*
* Helper: Ensure buffer has capacity for one more line
*/
static mrb_bool
buffer_ensure_line_cap(mirb_buffer *buf)
{
if (buf->line_count < buf->line_cap) return TRUE;
size_t new_cap = buf->line_cap * 2;
if (new_cap > MIRB_BUF_LINES_MAX) return FALSE;
mirb_line *new_lines = (mirb_line*)realloc(buf->lines, sizeof(mirb_line) * new_cap);
if (new_lines == NULL) return FALSE;
buf->lines = new_lines;
buf->line_cap = new_cap;
return TRUE;
}
/*
* Initialize buffer
*/
@@ -396,14 +412,7 @@ mirb_buffer_set_string(mirb_buffer *buf, const char *str)
/* Set current line */
if (line_idx >= buf->line_count) {
/* Need to add new line */
if (buf->line_count >= buf->line_cap) {
size_t new_cap = buf->line_cap * 2;
if (new_cap > MIRB_BUF_LINES_MAX) return FALSE;
mirb_line *new_lines = (mirb_line*)realloc(buf->lines, sizeof(mirb_line) * new_cap);
if (new_lines == NULL) return FALSE;
buf->lines = new_lines;
buf->line_cap = new_cap;
}
if (!buffer_ensure_line_cap(buf)) return FALSE;
if (!line_init(&buf->lines[buf->line_count])) return FALSE;
buf->line_count++;
}
@@ -421,14 +430,7 @@ mirb_buffer_set_string(mirb_buffer *buf, const char *str)
/* Handle last line (may not end with newline) */
if (start < p || line_idx == 0) {
if (line_idx >= buf->line_count) {
if (buf->line_count >= buf->line_cap) {
size_t new_cap = buf->line_cap * 2;
if (new_cap > MIRB_BUF_LINES_MAX) return FALSE;
mirb_line *new_lines = (mirb_line*)realloc(buf->lines, sizeof(mirb_line) * new_cap);
if (new_lines == NULL) return FALSE;
buf->lines = new_lines;
buf->line_cap = new_cap;
}
if (!buffer_ensure_line_cap(buf)) return FALSE;
if (!line_init(&buf->lines[buf->line_count])) return FALSE;
buf->line_count++;
}
@@ -581,14 +583,7 @@ mrb_bool
mirb_buffer_newline(mirb_buffer *buf)
{
/* Ensure we have room for a new line */
if (buf->line_count >= buf->line_cap) {
size_t new_cap = buf->line_cap * 2;
if (new_cap > MIRB_BUF_LINES_MAX) return FALSE;
mirb_line *new_lines = (mirb_line*)realloc(buf->lines, sizeof(mirb_line) * new_cap);
if (new_lines == NULL) return FALSE;
buf->lines = new_lines;
buf->line_cap = new_cap;
}
if (!buffer_ensure_line_cap(buf)) return FALSE;
mirb_line *curr = &buf->lines[buf->cursor_line];
size_t split_pos = buf->cursor_col;