admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

dump.c: consolidate error handling in mrb_dump_irep_cfunc()

Browse Source 
replace four repeated `mrb_free(mrb, bin); return MRB_DUMP_WRITE_FAULT`
sequences with a single goto-based cleanup path.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2026-03-18 14:01:59 +09:00
parent 16fbd56e4b
commit 0b79c70935
1 changed files with 24 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dump.c
+24 -33
View File
@@ -957,40 +957,31 @@ mrb_dump_irep_cfunc(mrb_state *mrb, const mrb_irep *irep, uint8_t flags, FILE *f
}
size_t bin_size, bin_idx = 0;
int result = mrb_dump_irep(mrb, irep, flags, &bin, &bin_size);
if (result == MRB_DUMP_OK) {
if (fprintf(fp, "#include <stdint.h>\n") < 0) { /* for uint8_t under at least Darwin */
mrb_free(mrb, bin);
return MRB_DUMP_WRITE_FAULT;
}
if (fprintf(fp,
"%s\n"
"const uint8_t %s[] = {",
(flags & MRB_DUMP_STATIC) ? "static"
: "#ifdef __cplusplus\n"
"extern\n"
"#endif",
initname) < 0) {
mrb_free(mrb, bin);
return MRB_DUMP_WRITE_FAULT;
}
while (bin_idx < bin_size) {
if (bin_idx % 16 == 0) {
if (fputs("\n", fp) == EOF) {
mrb_free(mrb, bin);
return MRB_DUMP_WRITE_FAULT;
}
}
if (fprintf(fp, "0x%02x,", bin[bin_idx++]) < 0) {
mrb_free(mrb, bin);
return MRB_DUMP_WRITE_FAULT;
}
}
if (fputs("\n};\n", fp) == EOF) {
mrb_free(mrb, bin);
return MRB_DUMP_WRITE_FAULT;
}
}
if (result != MRB_DUMP_OK) goto exit;
if (fprintf(fp, "#include <stdint.h>\n") < 0) /* for uint8_t under at least Darwin */
goto write_error;
if (fprintf(fp,
"%s\n"
"const uint8_t %s[] = {",
(flags & MRB_DUMP_STATIC) ? "static"
: "#ifdef __cplusplus\n"
"extern\n"
"#endif",
initname) < 0)
goto write_error;
while (bin_idx < bin_size) {
if (bin_idx % 16 == 0) {
if (fputs("\n", fp) == EOF) goto write_error;
}
if (fprintf(fp, "0x%02x,", bin[bin_idx++]) < 0) goto write_error;
}
if (fputs("\n};\n", fp) == EOF) goto write_error;
goto exit;
write_error:
result = MRB_DUMP_WRITE_FAULT;
exit:
mrb_free(mrb, bin);
return result;
}