admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-bigint: use limb_zero for memory initialization

Browse Source 
Refactor `mpz_init_heap` and `mpz_realloc` to use the existing
`limb_zero` helper function for zero-initializing memory. This
reduces code duplication and improves consistency.

Co-authored-by: Gemini <gemini@google.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-07-31 16:14:51 +09:00
parent ea7843edd4
commit 19f9675743
1 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bigint/core/bigint.c
+9 -16
View File
@@ -90,6 +90,13 @@ pool_alloc(mpz_pool_t *pool, size_t limbs)
}
#endif
/* Zero n limbs at p */
static inline void
limb_zero(mp_limb *p, size_t n)
{
memset(p, 0, n * sizeof(mp_limb));
}
static void
mpz_init(mpz_ctx_t *ctx, mpz_t *s)
{
@@ -98,8 +105,6 @@ mpz_init(mpz_ctx_t *ctx, mpz_t *s)
s->sz = 0;
}
/* New simplified API - temporary names during migration */
/* Heap-preferred allocation */
static void
mpz_init_heap(mpz_ctx_t *ctx, mpz_t *s, size_t hint)
@@ -107,10 +112,7 @@ mpz_init_heap(mpz_ctx_t *ctx, mpz_t *s, size_t hint)
s->sn = 0;
if (hint > 0) {
s->p = mrb_malloc(MPZ_MRB(ctx), hint * sizeof(mp_limb));
/* Zero-initialize the memory for predictable behavior */
for (size_t i = 0; i < hint; i++) {
s->p[i] = 0;
}
limb_zero(s->p, hint);
s->sz = hint;
}
else {
@@ -186,9 +188,7 @@ mpz_realloc(mpz_ctx_t *ctx, mpz_t *x, size_t size)
#endif
/* Zero-initialize new limbs */
for (size_t i = old_sz; i < size; i++) {
x->p[i] = 0;
}
limb_zero(x->p + old_sz, size - old_sz);
x->sz = size;
}
}
@@ -712,13 +712,6 @@ mpz_sub_int(mpz_ctx_t *ctx, mpz_t *x, mrb_int n)
trim(x);
}
/* Zero n limbs at p */
static inline void
limb_zero(mp_limb *p, size_t n)
{
memset(p, 0, n * sizeof(mp_limb));
}
/* Multiply-and-add: rp[0..n-1] += s1p[0..n-1] * limb; return carry (high limb) */
static inline mp_limb
limb_addmul_1(mp_limb *restrict rp, const mp_limb *restrict s1p, size_t n, mp_limb limb)