admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Preventing Memory Leaks in Array#__combination_init

Browse Source 
If memory allocated with `mrb_malloc()` is not associated with an object, subsequent attempts to allocate memory or objects will fail and raise an exception, resulting in a memory leak.
This commit is contained in:
dearblue
2025-10-26 16:29:06 +09:00
parent bd3b5f87fb
commit 2512b4b399
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-array-ext/src/array.c
+7 -4
View File
@@ -1316,7 +1316,13 @@ ary_combination_init(mrb_state *mrb, mrb_value self)
mrb_get_args(mrb, "ib", &n, &permutation);
/* prepare objects in first to avoid memory leaks caused by NoMemoryError exceptions */
struct RData *d = mrb_data_object_alloc(mrb, mrb->object_class, NULL, NULL);
struct mrb_combination_state *state = (struct mrb_combination_state*)mrb_malloc(mrb, sizeof(*state));
d->data = state;
d->type = &mrb_combination_state_type;
state->indices = NULL;
state->n = n;
state->array_size = RARRAY_LEN(self);
state->permutation = permutation;
@@ -1328,11 +1334,8 @@ ary_combination_init(mrb_state *mrb, mrb_value self)
state->indices[i] = 0;
}
}
else {
state->indices = NULL;
}
return mrb_obj_value(mrb_data_object_alloc(mrb, mrb->object_class, state, &mrb_combination_state_type));
return mrb_obj_value(d);
}
/*