Prevent splicing big recursive arrrays; ref #3679

We know this is not perfect, but this change makes hack like #3679
bit harder. Harmless for useful cases.
This commit is contained in:
Yukihiro "Matz" Matsumoto
2017-05-31 23:03:39 +09:00
parent b4a4e3c09a
commit 2837de95fe
+6 -1
View File
@@ -620,7 +620,12 @@ mrb_ary_splice(mrb_state *mrb, mrb_value ary, mrb_int head, mrb_int len, mrb_val
argc = RARRAY_LEN(rpl);
argv = RARRAY_PTR(rpl);
if (argv == a->ptr) {
struct RArray *r = ary_dup(mrb, a);
struct RArray *r;
if (argc > 32767) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "too big recursive splice");
}
r = ary_dup(mrb, a);
argv = r->ptr;
}
}