Add validation for C language symbol name

This commit is contained in:
h2so5
2013-04-09 16:19:27 +09:00
parent 1b40c057f5
commit 337076f9ba
2 changed files with 21 additions and 1 deletions
+17 -1
View File
@@ -499,6 +499,22 @@ mrb_dump_irep_binary(mrb_state *mrb, size_t start_index, int debug_info, FILE* f
return result;
}
static int
is_valid_c_symbol_name(const char *name)
{
const char *c = NULL;
if (name == NULL || name[0] == '\0') return 0;
if (!ISALPHA(name[0]) && name[0] != '_') return 0;
c = &name[1];
for (; *c != '\0'; ++c) {
if (!ISALNUM(*c) && *c != '_') return 0;
}
return 1;
}
int
mrb_dump_irep_cfunc(mrb_state *mrb, size_t start_index, int debug_info, FILE *fp, const char *initname)
{
@@ -506,7 +522,7 @@ mrb_dump_irep_cfunc(mrb_state *mrb, size_t start_index, int debug_info, FILE *fp
size_t bin_size = 0, bin_idx = 0;
int result;
if (fp == NULL || initname == NULL) {
if (fp == NULL || initname == NULL || !is_valid_c_symbol_name(initname)) {
return MRB_DUMP_INVALID_ARGUMENT;
}
+4
View File
@@ -215,6 +215,10 @@ main(int argc, char **argv)
}
if (args.initname) {
n = mrb_dump_irep_cfunc(mrb, n, args.debug_info, args.wfp, args.initname);
if (n == MRB_DUMP_INVALID_ARGUMENT) {
printf("%s: Invalid C language symbol name\n", args.initname);
return EXIT_FAILURE;
}
}
else {
n = mrb_dump_irep_binary(mrb, n, args.debug_info, args.wfp);