admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-bigint: use designated initializers for pool storage

Browse Source 
Simplified pool initialization from 4 lines to 2 using C99 designated
initializers:

Before:
  mpz_pool_t pool_storage = {0};
  pool_storage.capacity = BIGINT_POOL_DEFAULT_SIZE;
  pool_storage.active = 1;
  mpz_pool_t *pool = &pool_storage;

After:
  mpz_pool_t pool_storage = {.capacity = BIGINT_POOL_DEFAULT_SIZE, .active = 1};
  mpz_pool_t *pool = &pool_storage;

Applied to both WITH_SCOPED_POOL macro and manual pool management
patterns. This makes pool initialization more readable and concise.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-07-26 09:47:15 +09:00
parent 5fcf4e10cd
commit 39db7d21b8
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bigint/core/bigint.c
+3 -7
View File
@@ -53,9 +53,7 @@ typedef struct allocation_stats {
static allocation_stats_t g_alloc_stats = {0};
#define WITH_SCOPED_POOL(pool_name, code) do { \
mpz_pool_t pool_name##_storage = {0}; \
pool_name##_storage.capacity = BIGINT_POOL_DEFAULT_SIZE; \
pool_name##_storage.active = 1; \
mpz_pool_t pool_name##_storage = {.capacity = BIGINT_POOL_DEFAULT_SIZE, .active = 1}; \
mpz_pool_t *pool_name = &pool_name##_storage; \
code \
pool_name##_storage.active = 0; \
@@ -1259,10 +1257,8 @@ udiv(mrb_state *mrb, mpz_t *qq, mpz_t *rr, mpz_t *xx, mpz_t *yy)
/* Estimate space needed for temporary variables */
size_t temp_space = dividend_limbs + 1 + divisor_limbs + (dividend_limbs - divisor_limbs + 1);
if (temp_space <= BIGINT_POOL_DEFAULT_SIZE / 3) {
/* Use manual pool management instead of macro */
mpz_pool_t pool_storage = {0};
pool_storage.capacity = BIGINT_POOL_DEFAULT_SIZE;
pool_storage.active = 1;
/* Use manual pool management with designated initializer */
mpz_pool_t pool_storage = {.capacity = BIGINT_POOL_DEFAULT_SIZE, .active = 1};
mpz_pool_t *pool = &pool_storage;
mpz_t q_temp, x_temp, y_temp;