admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid using the deprecated function mrb_data_check_and_get()

Browse Source 
The "d" directive in `mrb_get_args()` can be used as an alternative.
Furthermore, NULL checking is unnecessary for the following reasons:
  - Incomplete objects from `ary_combination_init()` are not passed to the caller and are garbage collected when `ObjectSpace.each_object` is called, so they are never retrieved
  - Even if `state.clone` is called, the `RData::type` of the cloned object is set to NULL, so it is rejected by `mrb_get_args()`
This commit is contained in:
dearblue
2026-04-08 21:10:45 +09:00
parent 5d5cf0c3ea
commit 3a9ef9d27e
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-array-ext/src/array.c
+1 -9
View File
@@ -1575,16 +1575,8 @@ ary_combination_init(mrb_state *mrb, mrb_value self)
static mrb_value
ary_combination_next(mrb_state *mrb, mrb_value self)
{
mrb_value state_obj;
mrb_get_args(mrb, "o", &state_obj);
struct mrb_combination_state *state;
/* Validate state object type and get data */
state = (struct mrb_combination_state*)mrb_data_check_and_get(mrb, state_obj, &mrb_combination_state_type);
if (!state) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "invalid combination state");
}
mrb_get_args(mrb, "d", &state, &mrb_combination_state_type);
/* Check if iteration is complete */
if (state->finished) return mrb_nil_value();