admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-bigint/bigint.c: fix int64/uint64 conversion

Browse Source 
The functions were totally wrong in digit order and sign treatment. We
didn't notice since they are only called from mruby-time in the m64-i32
configuration.
This commit is contained in:
Yukihiro "Matz" Matsumoto
2023-04-03 08:55:48 +09:00
parent 65897145aa
commit 3d2cf0d9bf
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bigint/core/bigint.c
+6 -3
View File
@@ -1186,12 +1186,14 @@ mrb_bint_as_int64(mrb_state *mrb, mrb_value x)
out_of_range:
mrb_raise(mrb, E_RANGE_ERROR, "integer out of range");
}
for (size_t i=0; i<len; i++) {
for (size_t i=len-1; ; i--) {
u <<= DIG_SIZE;
u |= m->p[i];
if (i==0) break;
}
if (u > INT64_MAX) goto out_of_range;
return -(int64_t)u;
if (m->sn < 0) return -(int64_t)u;
return (int64_t)u;
}
#endif
@@ -1206,9 +1208,10 @@ mrb_bint_as_uint64(mrb_state *mrb, mrb_value x)
if (m->sn < 0 || len*sizeof(mp_limb) > sizeof(uint64_t)) {
mrb_raise(mrb, E_RANGE_ERROR, "integer out of range");
}
for (size_t i=0; i<len; i++) {
for (size_t i=len-1; ; i--) {
u <<= DIG_SIZE;
u |= m->p[i];
if (i==0) break;
}
return u;
}