admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make Proc#parameters to support keyword arguments; fix #5066

Browse Source 
TODO: Unlike CRuby, mruby's `Proc#parameters` does not distinguish
required keyword arguments and optional keyword arguments currently.
This commit is contained in:
Yukihiro "Matz" Matsumoto
2020-08-17 17:21:56 +09:00
parent 02e69d1c2c
commit 424afa4446
4 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/mruby/proc.h
+1 -1
View File
@@ -57,7 +57,7 @@ struct RProc {
#define MRB_ASPEC_REST(a) (((a) >> 12) & 0x1)
#define MRB_ASPEC_POST(a) (((a) >> 7) & 0x1f)
#define MRB_ASPEC_KEY(a) (((a) >> 2) & 0x1f)
#define MRB_ASPEC_KDICT(a) ((a) & (1<<1))
#define MRB_ASPEC_KDICT(a) (((a) >> 1) & 0x1)
#define MRB_ASPEC_BLOCK(a) ((a) & 1)
#define MRB_PROC_CFUNC_FL 128
mrbgems/mruby-compiler/core/parse.y
+1 -1
View File
@@ -3791,7 +3791,7 @@ f_rest_arg : restarg_mark tIDENTIFIER
}
| restarg_mark
{
local_add_f(p, MRB_QSYM(and));
local_add_f(p, MRB_QSYM(mul));
$$ = -1;
}
;
mrbgems/mruby-compiler/core/y.tab.c
+1 -1
View File
@@ -9442,7 +9442,7 @@ yyreduce:
case 554:
#line 3793 "mrbgems/mruby-compiler/core/parse.y"
{
local_add_f(p, MRB_QSYM(and));
local_add_f(p, MRB_QSYM(mul));
(yyval.id) = -1;
}
#line 9449 "mrbgems/mruby-compiler/core/y.tab.c"
mrbgems/mruby-proc-ext/src/proc.c
+25 -14
View File
@@ -91,21 +91,24 @@ static mrb_value
mrb_proc_parameters(mrb_state *mrb, mrb_value self)
{
struct parameters_type {
size_t len;
const char *name;
mrb_sym name;
int size;
} *p, parameters_list [] = {
{sizeof("req") - 1, "req", 0},
{sizeof("opt") - 1, "opt", 0},
{sizeof("rest") - 1, "rest", 0},
{sizeof("req") - 1, "req", 0},
{sizeof("block") - 1, "block", 0},
{0, NULL, 0}
{MRB_SYM(req), 0},
{MRB_SYM(opt), 0},
{MRB_SYM(rest), 0},
{MRB_SYM(req), 0},
{MRB_SYM(keyrest), 0},
{MRB_SYM(block), 0},
{MRB_SYM(key), 0},
{0, 0}
};
const struct RProc *proc = mrb_proc_ptr(self);
const struct mrb_irep *irep = proc->body.irep;
mrb_aspec aspec;
mrb_value parameters;
mrb_value krest = mrb_nil_value();
mrb_value block = mrb_nil_value();
int i, j;
int max = -1;
@@ -124,10 +127,8 @@ mrb_proc_parameters(mrb_state *mrb, mrb_value self)
}
if (!MRB_PROC_STRICT_P(proc)) {
parameters_list[0].len = sizeof("opt") - 1;
parameters_list[0].name = "opt";
parameters_list[3].len = sizeof("opt") - 1;
parameters_list[3].name = "opt";
parameters_list[0].name = MRB_SYM(opt);
parameters_list[3].name = MRB_SYM(opt);
}
aspec = PEEK_W(irep->iseq+1);
@@ -135,13 +136,15 @@ mrb_proc_parameters(mrb_state *mrb, mrb_value self)
parameters_list[1].size = MRB_ASPEC_OPT(aspec);
parameters_list[2].size = MRB_ASPEC_REST(aspec);
parameters_list[3].size = MRB_ASPEC_POST(aspec);
parameters_list[4].size = MRB_ASPEC_BLOCK(aspec);
parameters_list[4].size = MRB_ASPEC_KDICT(aspec);
parameters_list[5].size = MRB_ASPEC_BLOCK(aspec);
parameters_list[6].size = MRB_ASPEC_KEY(aspec);
parameters = mrb_ary_new_capa(mrb, irep->nlocals-1);
max = irep->nlocals-1;
for (i = 0, p = parameters_list; p->name; p++) {
mrb_value sname = mrb_symbol_value(mrb_intern_static(mrb, p->name, p->len));
mrb_value sname = mrb_symbol_value(p->name);
for (j = 0; j < p->size; i++, j++) {
mrb_value a;
@@ -159,9 +162,17 @@ mrb_proc_parameters(mrb_state *mrb, mrb_value self)
break;
}
}
if (p->name == MRB_SYM(block)) {
block = a; continue;
}
if (p->name == MRB_SYM(keyrest)) {
krest = a; continue;
}
mrb_ary_push(mrb, parameters, a);
}
}
if (!mrb_nil_p(krest)) mrb_ary_push(mrb, parameters, krest);
if (!mrb_nil_p(block)) mrb_ary_push(mrb, parameters, block);
return parameters;
}