admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6227 from leviongit/array/shuffle_b

Browse Source 
fix: `Array#shuffle(!)` result distribution
This commit is contained in:
Yukihiro "Matz" Matsumoto
2024-04-05 08:33:04 +09:00
committed by GitHub
parent 88792e0d9a ad62d7809e
commit 47642f70cb
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-random/src/random.c
+2 -3
View File
@@ -261,7 +261,7 @@ static mrb_value
mrb_ary_shuffle_bang(mrb_state *mrb, mrb_value ary)
{
if (RARRAY_LEN(ary) > 1) {
mrb_int i, max;
mrb_int i;
rand_state *random;
mrb_sym kname = MRB_SYM(random);
mrb_value r;
@@ -270,13 +270,12 @@ mrb_ary_shuffle_bang(mrb_state *mrb, mrb_value ary)
mrb_get_args(mrb, ":", &kw);
random = check_random_arg(mrb, r);
mrb_ary_modify(mrb, mrb_ary_ptr(ary));
max = RARRAY_LEN(ary);
for (i = RARRAY_LEN(ary) - 1; i > 0; i--) {
mrb_int j;
mrb_value *ptr = RARRAY_PTR(ary);
mrb_value tmp;
j = rand_i(random, max);
j = rand_i(random, i + 1);
tmp = ptr[i];
ptr[i] = ptr[j];