admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-array-ext/array.c (mrb_ary_slice_bang): refactor.

Browse Source 
Use `mrb_ary_new_from_value()` instead of adding individual elements
using a loop.
This commit is contained in:
Yukihiro "Matz" Matsumoto
2022-10-15 08:46:48 +09:00
parent d84daa56fa
commit 5c2f3f72a4
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-array-ext/src/array.c
+3 -7
View File
@@ -139,7 +139,7 @@ static mrb_value
mrb_ary_slice_bang(mrb_state *mrb, mrb_value self)
{
struct RArray *a = mrb_ary_ptr(self);
mrb_int i, j, k, len, alen;
mrb_int i, j, len, alen;
mrb_value *ptr;
mrb_value ary;
@@ -166,13 +166,9 @@ mrb_ary_slice_bang(mrb_state *mrb, mrb_value self)
if (alen == i) return mrb_ary_new(mrb);
if (len > alen - i) len = alen - i;
ary = mrb_ary_new_capa(mrb, len);
ptr = ARY_PTR(a);
for (j = i, k = 0; k < len; ++j, ++k) {
mrb_ary_push(mrb, ary, ptr[j]);
}
ptr = ARY_PTR(a) + i;
ary = mrb_ary_new_from_values(mrb, len, ptr);
ptr += i;
for (j = i; j < alen - len; ++j) {
*ptr = *(ptr+len);
++ptr;