admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

arry.c: optimize Array#sort! comparison for common types

Browse Source 
Add fast-path comparisons for integers, floats, and strings in Array#sort!
when no custom comparison block is provided. This reduces VM callback
overhead for common data types, improving performance.

Co-authored-by: Gemini <gemini@google.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-06-30 14:41:45 +09:00
parent 6d8c673efb
commit 6fab19cd82
1 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/array.c
+26 -2
View File
@@ -1823,8 +1823,32 @@ sort_cmp(mrb_state *mrb, mrb_value ary, mrb_value *p, mrb_int a, mrb_int b, mrb_
mrb_int cmp;
if (mrb_nil_p(blk)) {
cmp = mrb_cmp(mrb, p[a], p[b]);
if (cmp == -2) cmp_failed(mrb, a, b);
enum mrb_vtype type_a = mrb_type(p[a]);
enum mrb_vtype type_b = mrb_type(p[b]);
if (type_a == type_b) {
switch (type_a) {
case MRB_TT_FIXNUM:
cmp = (mrb_fixnum(p[a]) > mrb_fixnum(p[b])) ? 1 : (mrb_fixnum(p[a]) < mrb_fixnum(p[b])) ? -1 : 0;
break;
#ifndef MRB_NO_FLOAT
case MRB_TT_FLOAT:
cmp = (mrb_float(p[a]) > mrb_float(p[b])) ? 1 : (mrb_float(p[a]) < mrb_float(p[b])) ? -1 : 0;
break;
#endif
case MRB_TT_STRING:
cmp = mrb_str_cmp(mrb, p[a], p[b]);
break;
default:
cmp = mrb_cmp(mrb, p[a], p[b]);
if (cmp == -2) cmp_failed(mrb, a, b);
break;
}
}
else {
cmp = mrb_cmp(mrb, p[a], p[b]);
if (cmp == -2) cmp_failed(mrb, a, b);
}
}
else {
mrb_value args[2] = {p[a], p[b]};