admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-binding: raise in upper count check

Browse Source 
We count `Proc` upper links then check for upper bounds (default:20),
but now we raise an exception as soon as the count exceeds the limit so
that we can avoid traverse unnecessary upper links.
This commit is contained in:
Yukihiro "Matz" Matsumoto
2023-12-15 18:17:43 +09:00
parent 24eca2e50b
commit 6fad067ded
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-binding/src/binding.c
+8 -9
View File
@@ -106,15 +106,17 @@ binding_env_new_lvspace(mrb_state *mrb, const struct REnv *e)
return env;
}
static size_t
binding_proc_upper_count(const struct RProc *proc)
static void
binding_check_proc_upper_count(mrb_state *mrb, const struct RProc *proc)
{
size_t count = 0;
for (; proc && !MRB_PROC_CFUNC_P(proc); proc = proc->upper) {
for (size_t count = 0; proc && !MRB_PROC_CFUNC_P(proc); proc = proc->upper) {
count++;
if (count > BINDING_UPPER_MAX) {
mrb_raise(mrb, E_RUNTIME_ERROR,
"too many upper procs for local variables (mruby limitation; maximum is " MRB_STRINGIZE(BINDING_UPPER_MAX) ")");
}
if (MRB_PROC_SCOPE_P(proc)) break;
}
return count;
}
mrb_bool
@@ -166,10 +168,7 @@ binding_initialize_copy(mrb_state *mrb, mrb_value binding)
lvspace = binding_wrap_lvspace(mrb, src_proc->upper, &env);
}
else {
if (binding_proc_upper_count(src_proc) > BINDING_UPPER_MAX) {
mrb_raise(mrb, E_RUNTIME_ERROR,
"too many upper procs for local variables (mruby limitation; maximum is " MRB_STRINGIZE(BINDING_UPPER_MAX) ")");
}
binding_check_proc_upper_count(mrb, src_proc);
env = src_env;
lvspace = binding_wrap_lvspace(mrb, src_proc, &env);