admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vm.c: use mrb_obj_ptr()->c for faster class check in GETIDX/SETIDX

Browse Source 
Replace mrb_obj_class() with direct mrb_obj_ptr(va)->c access:

- Skips unnecessary mrb_immediate_p() check (these types are never immediate)
- Skips mrb_class_real() traversal for singleton classes
- Objects with singleton methods now fall back to method dispatch
  (correct behavior since they might have overridden []/[]=)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-12-25 02:40:41 +09:00
parent 115438aa1e
commit 8a29ab591e
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vm.c
+10 -10
View File
@@ -1880,8 +1880,8 @@ RETRY_TRY_BLOCK:
mrb_value va = regs[a], vb = regs[a+1];
switch (mrb_type(va)) {
case MRB_TT_ARRAY:
/* optimize only for Array class; subclasses may override [] */
if (mrb_obj_class(mrb, va) != mrb->array_class) goto getidx_fallback;
/* optimize only for Array class; subclasses/singleton may override [] */
if (mrb_obj_ptr(va)->c != mrb->array_class) goto getidx_fallback;
if (!mrb_integer_p(vb)) goto getidx_fallback;
else {
mrb_int idx = mrb_integer(vb);
@@ -1894,15 +1894,15 @@ RETRY_TRY_BLOCK:
}
break;
case MRB_TT_HASH:
/* optimize only for Hash class; subclasses may override [] */
if (mrb_obj_class(mrb, va) != mrb->hash_class) goto getidx_fallback;
/* optimize only for Hash class; subclasses/singleton may override [] */
if (mrb_obj_ptr(va)->c != mrb->hash_class) goto getidx_fallback;
va = mrb_hash_get(mrb, va, vb);
ci = mrb->c->ci;
regs[a] = va;
break;
case MRB_TT_STRING:
/* optimize only for String class; subclasses may override [] */
if (mrb_obj_class(mrb, va) != mrb->string_class) goto getidx_fallback;
/* optimize only for String class; subclasses/singleton may override [] */
if (mrb_obj_ptr(va)->c != mrb->string_class) goto getidx_fallback;
switch (mrb_type(vb)) {
case MRB_TT_INTEGER:
case MRB_TT_STRING:
@@ -1926,16 +1926,16 @@ RETRY_TRY_BLOCK:
mrb_value va = regs[a], vb = regs[a+1], vc = regs[a+2];
switch (mrb_type(va)) {
case MRB_TT_ARRAY:
/* optimize only for Array class; subclasses may override []= */
if (mrb_obj_class(mrb, va) != mrb->array_class) goto setidx_fallback;
/* optimize only for Array class; subclasses/singleton may override []= */
if (mrb_obj_ptr(va)->c != mrb->array_class) goto setidx_fallback;
if (!mrb_integer_p(vb)) goto setidx_fallback;
mrb_ary_set(mrb, va, mrb_integer(vb), vc);
ci = mrb->c->ci;
regs[a] = vc;
NEXT;
case MRB_TT_HASH:
/* optimize only for Hash class; subclasses may override []= */
if (mrb_obj_class(mrb, va) != mrb->hash_class) goto setidx_fallback;
/* optimize only for Hash class; subclasses/singleton may override []= */
if (mrb_obj_ptr(va)->c != mrb->hash_class) goto setidx_fallback;
mrb_hash_set(mrb, va, vb, vc);
ci = mrb->c->ci;
regs[a] = vc;