admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix lshift() bit overflow; close #3023

Browse Source
This commit is contained in:
murase_syuka
2015-11-18 00:15:47 +09:00
committed by Yukihiro "Matz" Matsumoto
parent 22464fe5a0
commit a4d5588101
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/numeric.c
+2 -1
View File
@@ -821,7 +821,8 @@ static mrb_value
lshift(mrb_state *mrb, mrb_int val, mrb_int width)
{
mrb_assert(width > 0);
if (width > NUMERIC_SHIFT_WIDTH_MAX) {
if ((width > NUMERIC_SHIFT_WIDTH_MAX) ||
(val > (MRB_INT_MAX >> width))) {
mrb_float f = (mrb_float)val;
while (width--) {
f *= 2;
test/t/integer.rb
+3
View File
@@ -147,6 +147,9 @@ assert('Integer#<<', '15.2.8.3.12') do
# Left Shift by a negative is Right Shift
assert_equal 23, 46 << -1
# Left Shift by 31 is bitShift overflow to SignedInt
assert_equal 2147483648, 1 << 31
end
assert('Integer#>>', '15.2.8.3.13') do