admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed the Visual Studio Version Check because it does not

Browse Source 
work with internationalized versions of Visual Studio. It will capture
the returned string in the local codepage encoding and make ruby exits
with an invalid UTF8 error message.

Also "Version" might be translated and not appear in the output.
This commit is contained in:
Lothar Scholz
2017-12-24 06:28:38 +01:00
parent 06f90a3b45
commit a9d0d90f74
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tasks/toolchains/visualcpp.rake
+10 -9
View File
@@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params|
conf.file_separator = '\\'
if require 'open3'
Open3.popen3 conf.cc.command do |_, _, e, _|
if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17
m = "# VS2010/2012 support will be dropped after the next release! #"
h = "#" * m.length
puts h, m, h
end
end
end
# Unreliable detection and will result in invalid encoding errors for localized versions of Visual C++
# if require 'open3'
# Open3.popen3 conf.cc.command do |_, _, e, _|
# if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17
# m = "# VS2010/2012 support will be dropped after the next release! #"
# h = "#" * m.length
# puts h, m, h
# end
# end
# end
end