admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-rational: inline int_lshift into rational_new_f

Browse Source 
Remove the static int_lshift function and directly call mrb_bint_lshift
at the only call site. This simplifies the code and avoids static
function name collision with src/numeric.c for future amalgamation
support.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-12-23 08:50:30 +09:00
parent 3d0b5c848a
commit ce570c28bb
1 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-rational/src/rational.c
+2 -22
View File
@@ -325,24 +325,6 @@ mrb_rational_new(mrb_state *mrb, mrb_int nume, mrb_int deno)
#define RAT_HUGE_VAL HUGE_VAL
#endif
#define mrb_int_fit_p(x,t) ((t)MRB_INT_MIN <= (x) && (x) <= (t)MRB_INT_MAX)
static mrb_value
int_lshift(mrb_state *mrb, mrb_value v, mrb_int n)
{
if (mrb_integer_p(v) && n < (mrb_int)sizeof(long) * CHAR_BIT) {
mrb_float f = (mrb_float)mrb_integer(v);
f *= 1L<<n;
if (mrb_int_fit_p(f, mrb_float))
return mrb_int_value(mrb, (mrb_int)f);
}
#ifndef RAT_BIGINT
rat_overflow(mrb);
#else
return mrb_bint_lshift(mrb, mrb_as_bint(mrb, v), n);
#endif
}
static mrb_value
rational_new_f(mrb_state *mrb, mrb_float f)
{
@@ -364,10 +346,8 @@ rational_new_f(mrb_state *mrb, mrb_float f)
#ifndef RAT_BIGINT
rat_overflow(mrb);
#else
mrb_value n = int_lshift(mrb, mrb_int_value(mrb, nume), exp);
if (mrb_bigint_p(n)) {
return rational_new_b(mrb, n, mrb_int_value(mrb, deno));
}
mrb_value n = mrb_bint_lshift(mrb, mrb_bint_new_int(mrb, nume), exp);
return rational_new_b(mrb, n, mrb_int_value(mrb, deno));
#endif
}
nume = temp;