Fix out-of-bound access

Get rid of out-of-bound access when single % at the end.
This commit is contained in:
Nobuyoshi Nakada
2017-03-13 23:49:49 +09:00
parent 191ee2596c
commit d8c4fe7bcb
2 changed files with 12 additions and 0 deletions
+1
View File
@@ -567,6 +567,7 @@ mrb_str_format(mrb_state *mrb, int argc, const mrb_value *argv, mrb_value fmt)
mrb_sym id = 0;
for (t = p; t < end && *t != '%'; t++) ;
if (t + 1 == end) ++t;
PUSH(p, t - p);
if (t >= end)
goto sprint_exit; /* end of fmt string */
+11
View File
@@ -30,3 +30,14 @@ assert("String#% with invalid chr") do
end
end
end
assert("String#% invalid format") do
assert_raise ArgumentError do
"%?" % ""
end
end
assert("String#% invalid format shared substring") do
fmt = ("x"*30+"%!")[0...-1]
assert_equal fmt, sprintf(fmt, "")
end