admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmdmisc.c: extract parse_file_line_spec() from parse_listcmd_args()

Browse Source 
Flatten 4-level nested parsing of list command arguments into
a separate parse_file_line_spec() function.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2026-02-24 09:03:59 +09:00
parent 1d52c7a3dd
commit e35c011537
1 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bin-debugger/tools/mrdb/cmdmisc.c
+23 -21
View File
@@ -270,35 +270,37 @@ replace_ext(mrb_state *mrb, const char *filename, const char *ext)
return s;
}
/* parse: <lineno> | <filename>:<lineno> | <filename> */
static void
parse_file_line_spec(mrb_state *mrb, char *arg, listcmd_parser_state *st)
{
char *p = arg;
if (parse_lineno(mrb, &p, st)) {
/* matched <lineno> or <lineno>,<lineno> */
}
else if (parse_filename(mrb, &p, st)) {
if (skip_char(&p, ':') && !parse_lineno(mrb, &p, st)) {
st->parse_error = TRUE;
}
}
else {
st->parse_error = TRUE;
}
if (*p != '\0') {
st->parse_error = TRUE;
}
}
static mrb_bool
parse_listcmd_args(mrb_state *mrb, mrdb_state *mrdb, listcmd_parser_state *st)
{
char *p;
switch (mrdb->wcnt) {
case 2:
p = mrdb->words[1];
/* mrdb->words[1] ::= <lineno> | <filename> ':' <lineno> | <filename> */
if (!parse_lineno(mrb, &p, st)) {
if (parse_filename(mrb, &p, st)) {
if (skip_char(&p, ':')) {
if (!parse_lineno(mrb, &p, st)) {
st->parse_error = TRUE;
}
}
}
else {
st->parse_error = TRUE;
}
}
if (*p != '\0') {
st->parse_error = TRUE;
}
parse_file_line_spec(mrb, mrdb->words[1], st);
break;
case 1:
case 0:
/* do nothing */
break;
default:
st->parse_error = TRUE;