admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-bigint: fix mrb_bint_copy to properly clone bigints

Browse Source 
mrb_bint_copy was creating reference to destination then destroying it
with mpz_init, causing copy to happen in orphaned memory. this made
clone return 0 instead of copying the bigint value.

fix extracts common mpz_t-to-rbigint transfer logic into bint_set
helper, used by both bint_new and mrb_bint_copy. eliminates code
duplication and properly copies source data to destination rbigint
structure, handling both embedded and heap storage cases.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-10-13 09:19:28 +09:00
parent 003bdf5031
commit f69fe329a9
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-bigint/core/bigint.c
+13 -6
View File
@@ -2749,10 +2749,10 @@ bint_as_mpz(struct RBigint *b, mpz_t *x)
x->sn = RBIGINT_SIGN(b);
}
static struct RBigint*
bint_new(mpz_ctx_t *ctx, mpz_t *x)
/* Transfer mpz_t data to RBigint structure */
static void
bint_set(mpz_ctx_t *ctx, struct RBigint *b, mpz_t *x)
{
struct RBigint *b = MRB_OBJ_ALLOC(MPZ_MRB(ctx), MRB_TT_BIGINT, MPZ_MRB(ctx)->integer_class);
if (x->sz <= RBIGINT_EMBED_SIZE_MAX) {
RBIGINT_SET_EMBED_SIZE(b, x->sz);
RBIGINT_SET_EMBED_SIGN(b, x->sn);
@@ -2769,6 +2769,13 @@ bint_new(mpz_ctx_t *ctx, mpz_t *x)
RBIGINT_SET_HEAP(b);
mpz_move(ctx, &b->as.heap, x);
}
}
static struct RBigint*
bint_new(mpz_ctx_t *ctx, mpz_t *x)
{
struct RBigint *b = MRB_OBJ_ALLOC(MPZ_MRB(ctx), MRB_TT_BIGINT, MPZ_MRB(ctx)->integer_class);
bint_set(ctx, b, x);
return b;
}
@@ -3540,12 +3547,12 @@ mrb_bint_rshift(mrb_state *mrb, mrb_value x, mrb_int width)
void
mrb_bint_copy(mrb_state *mrb, mrb_value x, mrb_value y)
{
mpz_t a, b;
mpz_t b, temp;
MPZ_CTX_INIT(mrb, ctx, pool);
bint_as_mpz(RBIGINT(x), &a);
bint_as_mpz(RBIGINT(y), &b);
mpz_init_set(ctx, &a, &b);
mpz_init_set(ctx, &temp, &b);
bint_set(ctx, RBIGINT(x), &temp);
}
size_t