Commit Graph

7004 Commits

Author SHA1 Message Date
Yukihiro "Matz" Matsumoto 1dfe38bea0 Merge pull request #3018 from zzak/add-mruby-cli-authors
Add contributors from mruby-cli project to AUTHORS file
2015-11-17 04:31:46 +09:00
Yukihiro "Matz" Matsumoto 6ce31f334e Merge pull request #3017 from Mav7/master
Added type annotation to YARD.
2015-11-17 02:54:19 +09:00
Mav7 6f43e95163 Added type annotation to YARD. 2015-11-16 12:39:52 -05:00
Yukihiro "Matz" Matsumoto ed6f3a0735 Merge pull request #3015 from murasesyuka/fix/fix_lshift_and_fix_rshift_doc
fix comment
2015-11-16 23:36:11 +09:00
murase_syuka cd1a566002 fix comment 2015-11-16 22:27:42 +09:00
Zachary Scott 31a8743d66 Add contributors from mruby-cli project to AUTHORS file 2015-11-16 15:44:38 +09:00
Yukihiro "Matz" Matsumoto 916630be1a Merge pull request #3013 from zzak/dont-pull-gems-by-default
This patch changes git gem behavior to never pull gems unless specified.
2015-11-16 12:03:20 +09:00
Zachary Scott 98285e6b16 This patch changes git gem behavior to never pull gems unless specified.
Since mgem's function almost the same as git gems, but you can see they already
avoid pulling from source after the gem has already been cloned.

 You can see from the `load_special_path_gem` method found in the file
`mruby_build_gem.rake`, or extracted here:

```ruby
if File.exist? mgem_list_dir
  git.run_pull mgem_list_dir, mgem_list_url if $pull_gems
else
  FileUtils.mkdir_p mgem_list_dir
  git.run_clone mgem_list_dir, mgem_list_url, "--depth 1"
end
```

Also, later in this same method; mgem will set the `git` params.
Doing this will trigger the following block:

```ruby
if File.exist?(gemdir)
  if $pull_gems
    git.run_pull gemdir, url
  else
    gemdir
  end
else
  # ... clone
end
```

You can see here, this checks if `$pull_gems` is enabled before pulling.

Lastly, the final condition for this method is here:

```ruby
if params[:checksum_hash]
  # Jump to the specified commit
  git.run_checkout gemdir, params[:checksum_hash]
else
  # Jump to the top of the branch
  git.run_checkout gemdir, branch if $pull_gems
end
```

What we changed was the `else` condition of this block to follow the same
behavior as the aforementioned code. In doing so, we can avoid two things:

* Excess `clone` calls can slow down builds (times number of gems used)
* We _don't_ want our code to _update_ during build

To explain, if during build time there are some changes in the gem we are
depending upon: updating during compile time could actually break our
application.

This is what we're trying to avoid.
2015-11-16 11:43:56 +09:00
Yukihiro "Matz" Matsumoto 85b5af6154 Merge branch 'nobu-feature/hash-cmp' 2015-11-15 05:15:37 +09:00
Yukihiro "Matz" Matsumoto fa86026a99 move Hash comparison methods to mruby-hash-ext gem 2015-11-15 05:15:20 +09:00
Yukihiro "Matz" Matsumoto 1fc90746a6 Merge branch 'feature/hash-cmp' of https://github.com/nobu/mruby into nobu-feature/hash-cmp 2015-11-15 05:11:45 +09:00
Yukihiro "Matz" Matsumoto 4e63ea9649 Merge pull request #3011 from Mav7/master
Added more YARD docs to mruby.h
2015-11-15 05:10:52 +09:00
Mav7 66a839eb54 Added more YARD docs to mruby.h 2015-11-14 05:37:10 -05:00
Nobuyoshi Nakada bf5f83ffda Add comparison methods to Hash 2015-11-14 17:05:57 +09:00
Yukihiro "Matz" Matsumoto 9c108002bf Merge pull request #3008 from Mav7/master
Added YARD documentation in mruby.h
2015-11-10 09:50:15 +09:00
Mav7 27146dca16 Added YARD documentation in mruby.h 2015-11-09 12:16:14 -05:00
Yukihiro "Matz" Matsumoto 0c4218b704 Merge pull request #3007 from mruby-debian/fix/fail_to_package_build
fail to debuild
2015-11-10 01:20:09 +09:00
Akira Mitsui 1238739997 fail to debuild 2015-11-09 23:57:45 +09:00
Yukihiro "Matz" Matsumoto 7090b5f07a Merge pull request #3006 from cremno/remove-ifdef-mrb_fixnum_shift
remove ifdef as MRB_FIXNUM_SHIFT is always defined
2015-11-08 21:38:47 +09:00
Yukihiro "Matz" Matsumoto b65bd3778d Merge pull request #3005 from cremno/fix-ambiguous-first-argument-warning
fix ambiguous first argument warning
2015-11-08 21:37:19 +09:00
Yukihiro "Matz" Matsumoto d6e1762346 Merge pull request #3004 from cremno/remove-return
remove return
2015-11-08 21:36:54 +09:00
Yukihiro "Matz" Matsumoto d3b323cf2f PR #2521 did not work for singleton classes for non-class objects; fix #3003 2015-11-07 15:51:00 +09:00
cremno d109e5b4e1 remove ifdef as MRB_FIXNUM_SHIFT is always defined 2015-11-06 19:27:39 +01:00
cremno bb141e5532 fix ambiguous first argument warning
/home/travis/build/mruby/mruby/test/t/float.rb:201:17:
ambiguous first argument; put parentheses or even spaces
2015-11-06 18:35:19 +01:00
cremno e18e2a44f0 remove return
The return type of the mrb_objspace_each_objects function is void.
So this return statement with an expression is unnecessary and
also violates a constraint. From C99 §6.8.6.4:
>A return statement with an expression shall not appear
>in a function whose return type is void.
2015-11-06 18:13:38 +01:00
Yukihiro "Matz" Matsumoto 8bad1954a4 mrb_get_args should consume argument even when type specifier with bang get nil; fix #3002 2015-10-28 09:36:48 +09:00
Yukihiro "Matz" Matsumoto 614927447a mrb_str_concat() may call VM resursively thus may reallocate VM stack; close #3000 2015-10-27 01:06:15 +09:00
Yukihiro "Matz" Matsumoto 57e30b3be3 Merge pull request #3001 from zzak/fix-mrbtest-task
Ensure mrbs dependency is maintained for mruby-test
2015-10-24 23:03:48 +09:00
Zachary Scott 1e3da80923 Ensure mrbs dependency is maintained for mruby-test 2015-10-24 21:14:54 +09:00
Yukihiro "Matz" Matsumoto 727f2485c9 Merge pull request #2999 from sagmor/better-docs
More Docs
2015-10-22 07:10:16 +09:00
Seba Gamboa d4238494eb Tag include/mruby/error.h functions with required mrbgem tag 2015-10-21 17:03:43 -03:00
Seba Gamboa 25c8e95365 Revert "Mark core gems with mrbgem tag"
This reverts commit 5cdcce8dbd.
2015-10-21 14:31:13 -03:00
Yukihiro "Matz" Matsumoto e5fbf9dfa2 align codedump output for OP_JMP 2015-10-22 00:37:42 +09:00
Yukihiro "Matz" Matsumoto 73fa6486c6 align codedump output for OP_RETURN 2015-10-22 00:36:51 +09:00
Yukihiro "Matz" Matsumoto 48771a357c loop() to return StopIteration#result; [ruby-bugs#11498] 2015-10-21 21:47:43 +09:00
Yukihiro "Matz" Matsumoto 7278fd1f1b loop may return StopIteration#result; [ruby-bugs#11498] 2015-10-21 21:47:25 +09:00
Yukihiro "Matz" Matsumoto f6c58616a2 Merge pull request #2997 from furunkel/gc_cleanup
GC cleanup
2015-10-21 21:38:24 +09:00
Yukihiro "Matz" Matsumoto b41f1180c8 fixed SEGV in mrb_parser_dump(NODE_COLON3) 2015-10-21 21:15:35 +09:00
furunkel 6b67590fda Merge branch 'master' of https://github.com/mruby/mruby into gc_cleanup 2015-10-21 11:17:58 +02:00
furunkel 0d8012f513 Merge upstream 2015-10-21 11:12:08 +02:00
Yukihiro "Matz" Matsumoto 68ba386213 Merge pull request #2879 from cremno/call-always-frexp-instead-of-frexpl
call always frexp() instead of frexpl()
2015-10-21 10:36:11 +09:00
Seba Gamboa 13b552538a Remove obvious warnings from docs 2015-10-20 12:48:31 -03:00
Seba Gamboa f0e9974221 Fix Unknown tag error 2015-10-20 12:16:47 -03:00
Seba Gamboa 45e70e4dd6 Fix enumerator doc errors 2015-10-20 12:16:47 -03:00
Seba Gamboa 5cdcce8dbd Mark core gems with mrbgem tag 2015-10-20 12:16:47 -03:00
Seba Gamboa 84b70886cd Add block to document mrb_value type 2015-10-20 12:16:46 -03:00
Seba Gamboa fe1275a6af Improved mrb_args_format table 2015-10-20 12:16:46 -03:00
Seba Gamboa e871b77f41 Increasing docs coverage 2015-10-20 12:16:46 -03:00
furunkel 1c6b1d0155 Prefix mrb_gc_state enum members, make color defines private 2015-10-20 10:54:47 +02:00
Yukihiro "Matz" Matsumoto fc4f0b9be7 do not assert is_dead() during mark phase; close #2825 ref #2996 #2769 2015-10-20 17:06:54 +09:00