admin/revng-revng
1
0
Fork 0
mirror of https://github.com/revng/revng synced 2026-06-21 14:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

InlineHelpers: limit loop-unroll to x86

Browse Source 
Only the x86 softfloat helpers iterate over the vector-register lanes
with bounded `for` loops (e.g. the packed `helper_*p[sd]` operate on
`XMM/ZMM_D(i)`). `fix-helpers` can only rewrite the per-lane CSV
accesses once those loops are unrolled. This step is not needed on other
archs, so we avoid it to save space on the generated libtcg helpers and
build time.
This commit is contained in:
Andrea Gussoni
2026-05-13 15:23:47 +02:00
committed by Alessandro Di Federico
parent 75059cfdff
commit b10024bfc8
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+18 -5
View File
@@ -246,20 +246,33 @@ foreach(
# `analyze-helper-arguments` can understand.
# * `analyze-helper-arguments` discovers, for every helper, which arguments
# alias CSVs at the call site.
# * `loop-unroll` unrolls loops so the subsequent `fix-helpers` pass can
# rewrite the accesses contained in bounded loops bodies.
# * `loop-unroll` (x86 only, see below) unrolls loops so the subsequent
# `fix-helpers` pass can rewrite the accesses contained in bounded loop
# bodies.
# * `fix-helpers` rewrites helper bodies to access CSVs via the env pointer,
# switching on env-relative offsets.
# * `detect-uninlinable-helpers` excludes not viable helpers from inlining.
# Only the x86 softfloat helpers iterate over the vector-register lanes with
# bounded `for` loops (e.g. the packed `helper_*p[sd]` operate on
# `XMM/ZMM_D(i)`). `fix-helpers` can only rewrite the per-lane CSV accesses
# once those loops are unrolled. This step is not needed on other archs, so we
# avoid it to save space on the generated libtcg helpers and build time.
set(EXTRA_HELPER_PASSES "")
if(ARCH STREQUAL "x86_64" OR ARCH STREQUAL "i386")
set(EXTRA_HELPER_PASSES -loop-unroll)
endif()
add_custom_command(
OUTPUT "${LIBTCG_HELPERS_FULL}"
DEPENDS "${LIBTCG_HELPERS}" revng-all-binaries revngHelperArgumentsAnalysis
revngHelperInliningAnalyses
COMMAND
./bin/revng opt -mark-inline-helpers-up-to -sroa -instsimplify
-cpu-loop-exit -analyze-helper-arguments -loop-unroll -fix-helpers
-fix-helpers-architecture="${ARCH}" -dce -detect-uninlinable-helpers
"${LIBTCG_HELPERS}" -o "${LIBTCG_HELPERS_FULL}")
-cpu-loop-exit -analyze-helper-arguments ${EXTRA_HELPER_PASSES}
-fix-helpers -fix-helpers-architecture="${ARCH}" -dce
-detect-uninlinable-helpers "${LIBTCG_HELPERS}" -o
"${LIBTCG_HELPERS_FULL}")
add_custom_target("annotated-libtcg-helpers-${ARCH}" ALL
DEPENDS "${LIBTCG_HELPERS_FULL}")