Minor improvements

include/revng/CliftEmitC/Configuration.h

@@ -9,7 +9,7 @@
 struct TypeEmitterConfiguration {
   /// We don't always want the complete type system. For example, when one
   /// of the types is being edited, we cannot include the type in question!
-  // As well as every type that depends on its definition.
+  /// As well as every type that depends on its definition.
   ///
   /// Note: the type is identified by its handle.
   llvm::StringRef TypeToOmit;

include/revng/Pipes/Containers.h

@@ -16,4 +16,5 @@ using DecompileStringMap = FunctionStringMap<&kinds::Decompiled,
                                              DecompileName,
                                              DecompileMime,
                                              DecompileExtension>;
+
 } // namespace revng::pipes

lib/ABI/FunctionType/Layout.cpp

@@ -460,7 +460,7 @@ Layout::Layout(const model::CABIFunctionDefinition &Function) {
 
       // Disambiguate scalar and aggregate arguments.
       // Scalars are passed by value,
-      // aggregates and pointer-to-copy values - as a pointer.
+      // aggregates and pointers-to-copy values - as a pointer.
       if (Distributed.UsesPointerToCopy)
         Current.Kind = ArgumentKind::PointerToCopy;
       else if (Current.Type->isScalar())

lib/CliftEmitC/TypeDefinitionEmitter.cpp

@@ -238,7 +238,7 @@ void TypeDefinitionEmitter::emitEnumDefinition(clift::EnumType Enum) {
     emitDoxygenComment(Enum);
     Tokens.emitKeyword(ptml::CTokenEmitter::Keyword::Enum);
 
-    clift::ValueType Type = Enum.getUnderlyingType();
+    mlir::Type Type = Enum.getUnderlyingType();
     emitCAttributes(clift::CAttributeListBuilder(Enum.getContext())
                       .setOrUpdate<"_ENUM_UNDERLYING">(Type)
                       .setOrUpdate<"_PACKED">()

lib/PTML/CTokenEmitter.cpp

@@ -539,8 +539,7 @@ void CTokenEmitter::emitIdentifier(llvm::StringRef Identifier,
 
   revng_check(!Identifier.empty());
   if (not validateIdentifier(Identifier)) {
-    revng_abort(("The specified identifier is not a valid C identifier: `"
-                 + Identifier + "`")
+    revng_abort(("`" + Identifier + "` is not a valid C identifier.")
                   .str()
                   .c_str());
   }

python/revng/pypeline/pipeline_parser.py

@@ -100,7 +100,7 @@ class PipelineParser:
             for preferred_artifact in artifact.preferred_artifacts:
                 if preferred_artifact not in artifact_names:
                     raise ValueError(
-                        f"Artifact {artifact.name} defines {preferred_artifact}"
+                        f"Artifact {artifact.name} defines {preferred_artifact} "
                         "as a preferred artifact but it does not exist"
                     )