fix failing CI and rename misleading workflow name (#2630)

This commit is contained in:
Jaël Champagne Gareau
2026-03-15 18:40:08 -04:00
committed by GitHub
parent be94694290
commit 03e8d14eee
5 changed files with 9 additions and 9 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
name: Performance check on Ubuntu 20.04 CI (GCC 9)
name: Performance check on Ubuntu 24.04 CI (GCC 13)
on:
push:
+2 -2
View File
@@ -1,4 +1,4 @@
name: Ubuntu 20.04 CI (GCC 9) without exceptions
name: Ubuntu 24.04 CI (GCC 13) without exceptions
on: [push, pull_request]
@@ -24,7 +24,7 @@ jobs:
cd .. &&
mkdir build &&
cd build &&
cmake -DSIMDJSON_DEVELOPER_MODE=ON -DSIMDJSON_GOOGLE_BENCHMARKS=ON -DSIMDJSON_GOOGLE_BENCHMARKS=ON -DSIMDJSON_EXCEPTIONS=OFF -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX:PATH=destination .. &&
cmake -DSIMDJSON_DEVELOPER_MODE=ON -DSIMDJSON_GOOGLE_BENCHMARKS=ON -DSIMDJSON_EXCEPTIONS=OFF -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX:PATH=destination .. &&
cmake --build . &&
ctest --output-on-failure -LE explicitonly -j &&
make install &&
+1 -1
View File
@@ -1,4 +1,4 @@
name: Ubuntu 20.04 CI (GCC 9) Without Threads
name: Ubuntu 24.04 CI (GCC 13) Without Threads
on: [push, pull_request]
+2 -2
View File
@@ -1,9 +1,9 @@
name: Ubuntu 20.04 CI (GCC 9) With Memory Sanitizer
name: Ubuntu 24.04 CI (GCC 13) With Memory Sanitizer
on: [push, pull_request]
jobs:
ubuntu-build-address-sanitizier:
ubuntu-build-address-sanitizer:
if: >-
! contains(toJSON(github.event.commits.*.message), '[skip ci]') &&
! contains(toJSON(github.event.commits.*.message), '[skip github]')
+3 -3
View File
@@ -387,7 +387,7 @@ simdjson_inline padded_memory_map::padded_memory_map(const char *filename) noexc
close(fd);
return; // failed to get file size, data will be nullptr
}
size = (size_t)st.st_size;
size = static_cast<size_t>(st.st_size);
size_t total_size = size + simdjson::SIMDJSON_PADDING;
void *anon_map =
mmap(NULL, total_size, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
@@ -402,13 +402,13 @@ simdjson_inline padded_memory_map::padded_memory_map(const char *filename) noexc
close(fd);
return; // failed to mmap file, data will be nullptr
}
data = (const char *)file_map;
data = static_cast<const char *>(file_map);
close(fd); // no longer needed after mapping
}
simdjson_inline padded_memory_map::~padded_memory_map() noexcept {
if (data != nullptr) {
munmap((void *)data, size + simdjson::SIMDJSON_PADDING);
munmap(const_cast<char *>(data), size + simdjson::SIMDJSON_PADDING);
}
}