Commit Graph

24 Commits

Author SHA1 Message Date
Brad Swain b118d4ed79 Inject cloud-init SSH rule on wake for Tailscale-locked snapshots
When waking a droplet hibernated with Tailscale lockdown, the snapshot's
UFW rules block SSH on eth0 while Tailscale is logged out — creating a
deadlock where SSH is needed to re-setup Tailscale but is blocked by the
firewall. Fix by injecting a cloud-init user_data script that opens SSH
on eth0 at first boot, which is cleaned up when lock_down_to_tailscale()
resets UFW during Tailscale re-setup.

Also adds wait_for_ssh() to verify SSH reachability before attempting
Tailscale setup (replacing a blind sleep), and enhances the security
warning when --no-tailscale is used with a previously locked snapshot.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-24 10:18:36 -05:00
Brad Swain e9b05351bc Abort hibernate when prepare_for_hibernate fails to secure SSH access
Previously, if the temporary UFW rule or SSH config update failed during
hibernate preparation, the function returned True and hibernate proceeded
to snapshot — producing a snapshot with no public SSH access. On wake,
such droplets were completely unreachable (Tailscale needs re-auth but
SSH is blocked on eth0).

Now prepare_for_hibernate returns None on failure, and the caller aborts
the hibernate. Also adds a warning to the --continue path since it
cannot verify the temp rule on a powered-off droplet.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-24 08:42:38 -05:00
Grzegorz Wierzowiecki b4df5c9d3a Offer to delete leftover hibernation snapshot on droplet destroy (#49)
* Offer to delete leftover hibernation snapshot on droplet destroy

When a user hibernates a droplet then wakes it up but declines to delete
the snapshot, the snapshot is left behind. If they later `dropkit destroy`
the droplet, the orphaned snapshot persists silently, incurring storage
costs. After destroying the droplet, check for a matching hibernation
snapshot and prompt the user to delete it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Change snapshot deletion default to 'no' in destroy command

Respect the user's earlier choice: if they declined to delete the
snapshot during wakeup, defaulting to 'yes' here would second-guess
that decision. Default to 'no' so the prompt is informational rather
than presumptive.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-23 18:17:28 +01:00
Riccardo Schirone 212306c568 Update default Ubuntu image to 25.10 and extract slug constants (#48)
* Update default Ubuntu image from 25.04 to 25.10

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Extract default region/size/image slugs into constants

Replace duplicated hardcoded strings across config.py, main.py, and
tests with DEFAULT_REGION, DEFAULT_SIZE, and DEFAULT_IMAGE constants
defined in config.py.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-23 10:01:13 +01:00
dependabot[bot] eba4cfcfa3 Bump astral-sh/setup-uv from 7.3.0 to 7.3.1 in the github-actions group (#47)
Bumps the github-actions group with 1 update: [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv).


Updates `astral-sh/setup-uv` from 7.3.0 to 7.3.1
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](https://github.com/astral-sh/setup-uv/compare/eac588ad8def6316056a12d4907a9d4d84ff7a3b...5a095e7a2014a4212f075830d4f7277575a9d098)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-version: 7.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-10 16:02:43 +01:00
Riccardo Schirone 0efeea52bb Add Jinja2 template validation test and pre-commit hook (#45)
* Remove escaped chars in comments

* Add Jinja2 template validation test and pre-commit hook

Catch template syntax errors early with a unit test that parses and
renders the default cloud-init template, and a pre-commit hook that
validates all templates in dropkit/templates/ on change.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-24 14:23:39 +01:00
Riccardo Schirone fde89df590 Fix Jinja2 escaping of zsh PROMPT in cloud-init template (#41)
* Fix Jinja2 escaping of zsh PROMPT in cloud-init template

The zsh PROMPT string contains `%` sequences that Jinja2 interprets
as template syntax. Wrap in {% raw %}...{% endraw %} to preserve
the literal prompt definition.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add a warning to the cloud-init jinja template

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 14:58:28 +01:00
dm 5982a3b55e Simplify CLAUDE.md project structure to directories only (#42)
Ran /claude-md-management:revise-claude-md to audit CLAUDE.md against
the actual codebase. The file-level tree was stale (missing lock.py,
ui.py, version_check.py and several test files). Replace with a
directory-only layout that won't drift when files are added.

Also document the --cov-fail-under=29 threshold from pyproject.toml.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-02-23 10:53:44 +01:00
William Tan c8fe3cd7c3 Show Tailscale IP in droplet list (#39)
Add a Tailscale IP column to `dropkit ls` output. The IP is read from
the SSH config — if the configured hostname is a Tailscale IP (100.x.x.x),
it's displayed; otherwise shows "—".

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:57:09 +01:00
William Tan b1a25d88d0 Fix Tailscale logout ordering to prevent SSH connectivity loss (#40)
Update both `prepare_for_hibernate` and `destroy` to switch SSH config
to the droplet's public IP before logging out of Tailscale. Previously,
the Tailscale logout happened first, which killed the Tailscale IP route
that SSH was using — causing the logout command itself to hang or fail.

Also adds `--verbose` flag to the `hibernate` command.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:50:04 +01:00
William Tan 5653454ea6 add some aliases, list => ls, destroy => rm (#38) 2026-02-20 08:46:16 +01:00
Akshith G dfa984831d Remove Zprezto/p10k and add Makefile help target (#37)
* Strip Zprezto and p10k from cloud-init shell config

* Add help as default Makefile target
2026-02-20 08:45:50 +01:00
dependabot[bot] e8bc422bcf Bump astral-sh/setup-uv from 7.2.0 to 7.3.0 in the github-actions group (#36)
Bumps the github-actions group with 1 update: [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv).


Updates `astral-sh/setup-uv` from 7.2.0 to 7.3.0
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](https://github.com/astral-sh/setup-uv/compare/61cb8a9741eeb8a550a1b8544337180c0fc8476b...eac588ad8def6316056a12d4907a9d4d84ff7a3b)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-version: 7.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-17 15:59:41 +01:00
William Tan 77069f5516 Allow resizing hibernated droplets by modifying the size tag (#34)
* allow resizing hibernated droplets by modifying the size tag

* Prevent removal of protected tags (owner, firewall) in untag_resource

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-16 12:49:24 -05:00
William Tan b5c099840b Fix macOS Tailscale CLI discovery for App Store installs (#35)
* Fix macOS Tailscale CLI discovery for App Store installs

On macOS, Tailscale installed via the App Store places its CLI at
/Applications/Tailscale.app/Contents/MacOS/Tailscale, which is not in
PATH. Add find_tailscale_cli() helper that checks PATH first, then
falls back to the macOS App Store location on darwin.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address PR feedback: better error message, remove excessive test

Distinguish "Tailscale not found" from "not running" when the local
check fails, so users know whether to install or start Tailscale.
Remove the overly comprehensive binary_vanishes race condition test.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-16 12:48:17 -05:00
Dan Guido 059fbf02db Rename Claude settings and update tobcloud references (#33)
- Rename .claude/settings.local.json to .claude/settings.json
- Add .claude/settings.local.json to .gitignore
- Replace uv run tobcloud with uv run dropkit in permissions

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-14 12:22:54 -05:00
dependabot[bot] 9dad1f0647 Bump cryptography from 46.0.3 to 46.0.5 (#32)
Bumps [cryptography](https://github.com/pyca/cryptography) from 46.0.3 to 46.0.5.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/46.0.3...46.0.5)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-version: 46.0.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-11 10:48:46 +01:00
Riccardo Schirone eae5bc1cf4 Generalize email domain handling in documentation and tests (#27)
* Generalize email domain handling in documentation and tests

- Add .worktrees/ to .gitignore for git worktree support
- Update _sanitize_email_for_username docstring to be domain-agnostic
- Change CLAUDE.md example from trailofbits.com to example.com
- Add tests for google.com, gmail.com, corporate, and plus addressing

The code already supported any email domain; this updates docs and
tests to reflect that capability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Address PR review comments

- Remove redundant trailofbits.com regex, simplify to split("@")[0]
- Rename test to clarify backwards compatibility intent

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Dan Guido <dan@trailofbits.com>
2026-02-09 19:26:59 +01:00
dependabot[bot] 714de47762 Bump pip from 25.3 to 26.0 (#31)
Bumps [pip](https://github.com/pypa/pip) from 25.3 to 26.0.
- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)
- [Commits](https://github.com/pypa/pip/compare/25.3...26.0)

---
updated-dependencies:
- dependency-name: pip
  dependency-version: '26.0'
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-09 09:34:16 +01:00
Riccardo Schirone 9895dd9d5e Fix known_hosts removal for hashed entries (#28)
Replace manual file parsing with ssh-keygen -R which properly handles
both hashed (|1|...) and unhashed entries. macOS and many Linux systems
use HashKnownHosts by default, making the previous implementation unable
to remove entries.

Changes:
- Use ssh-keygen -R for each hostname instead of parsing the file
- Detect successful removal via "updated" in stdout
- Backup files are now .old (ssh-keygen default) instead of .bak
- Bracketed entries ([host]:port) now require exact format

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 15:58:05 -05:00
dm a875f3d430 Rename tobcloud references to dropkit in tests (#29)
* Rename tobcloud references to dropkit in tests

Update test data and test method names to use the new project name.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Format test_ssh_config.py

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 15:57:55 -05:00
dm 3b4db20ae6 Add CODEOWNERS file (#30)
Assigns @ret2libc as code owner for all files in the repository.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 15:57:48 -05:00
dependabot[bot] 50a2661d98 Bump the github-actions group with 2 updates (#26)
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv).


Updates `actions/checkout` from 4.2.2 to 6.0.2
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/11bd71901bbe5b1630ceea73d27597364c9af683...de0fac2e4500dabe0009e67214ff5f5447ce83dd)

Updates `astral-sh/setup-uv` from 5.4.1 to 7.2.0
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](https://github.com/astral-sh/setup-uv/compare/0c5e2b8115b80b4c7c5ddf6ffdd634974642d182...61cb8a9741eeb8a550a1b8544337180c0fc8476b)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: astral-sh/setup-uv
  dependency-version: 7.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-29 21:55:35 -05:00
Dan Guido bc36073036 Initial commit 2026-01-29 21:53:58 -05:00