Fix OpenCover.console.exe parameter ordering issue. (#2854)

* Fix OpenCover.console.exe parameter ordering issue.

The targetargs parameter needs to be at the end, otherwise everything
after that is considered as part of targetargs.

* Addressed code review comments

* Removed unnecessary file
This commit is contained in:
Aditya Patwardhan
2016-12-08 09:47:03 -08:00
committed by Dongbo Wang
parent 32a8601f92
commit 49d5b6ab4f
+2 -2
View File
@@ -412,8 +412,8 @@ function Invoke-OpenCover
}
$targetArgString = $targetArgs -join " "
# the order seems to be important
$openCoverArgs = "-target:$target","-targetargs:""$targetArgString""","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all"
# the order seems to be important. Always keep -targetargs as the last parameter.
$openCoverArgs = "-target:$target","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all","-targetargs:`"$targetArgString`""
if ( $PSCmdlet.ShouldProcess("$OpenCoverBin $openCoverArgs") )
{