replace the word hang with something more appropriate (#5358)

This commit is contained in:
Steve Lee
2017-11-08 13:47:12 -08:00
committed by Travis Plunk
parent 906d0a5576
commit 5f5407595d
24 changed files with 33 additions and 33 deletions
+2 -2
View File
@@ -447,7 +447,7 @@ For more information on this, we invite you to read [this blog post explaining P
### Remoting
- Fixed hang when the SSH client abruptly terminates. (#4123)
- Fixed PowerShell not responding when the SSH client abruptly terminates. (#4123)
### Documentation
@@ -778,7 +778,7 @@ We made a number of fixes to the progress bar rendering and the `ProgressRecord`
- Add '-Title' to 'Get-Credential' and unify the prompt experience
- Update dependency list for PowerShell Core on Linux and OS X
- Fix 'powershell -Command -' to not hang and to not ignore the last command
- Fix 'powershell -Command -' to not stop responding and to not ignore the last command
- Fix binary operator tab completion
- Enable 'ConvertTo-Html' in PowerShell Core
- Remove most Maximum* capacity variables
@@ -614,7 +614,7 @@ namespace Microsoft.PowerShell.Commands
if (!isInternetExplorerConfigurationComplete)
{
// Verify that if IE is installed, it has been through the RunOnce check.
// Otherwise, the call will hang waiting for users to go through First Run
// Otherwise, the call will stop responding waiting for users to go through First Run
// personalization.
using (RegistryKey key = Registry.CurrentUser.OpenSubKey("Software\\Microsoft\\Internet Explorer\\Main"))
{
@@ -66,7 +66,7 @@ namespace System.Management.Automation.ComInterop
/// an instance of BoundDispEvent class. This class has InPlaceAdd and
/// InPlaceSubtract operators defined. Calling InPlaceAdd operator will:
/// 1. An instance of ComEventSinksContainer class is created (unless
/// RCW already had one). This instance is hanged off the RCW in attempt
/// RCW already had one). This instance is associated to the RCW in attempt
/// to bind the lifetime of event sinks to the lifetime of the RCW itself,
/// meaning event sink will be collected once the RCW is collected (this
/// is the same way event sinks lifetime is controlled by PIAs).
@@ -664,7 +664,7 @@ namespace System.Management.Automation.Language
}
}
// Catch any hanging parameters at the end of the command
// Catch any extra parameters at the end of the command
if (currentParameter != null)
{
// Assume it was a switch
@@ -991,7 +991,7 @@ namespace System.Management.Automation
// invocation to the current runspace, we took dependency on eventing infrastructure and
// this required ensuring the event and associated action be processed in the current thread
// synchronously. The below while loop was added for that (win8: 530495). However, fix for
// 530495 resulted in hang for icm | % { icm } case and dynamic event/subscriptions scenarios.
// 530495 resulted in not responding for icm | % { icm } case and dynamic event/subscriptions scenarios.
// To overcome that, changed "processSynchronously" parameter to "processInCurrentThread" and added
// a new parameter "waitForCompletionWhenInCurrentThread" to trigger blocking for ScriptBlock
// case.
@@ -137,7 +137,7 @@ namespace Microsoft.PowerShell.Commands
Dictionary<PSModuleInfo, List<PSModuleInfo>> actualModulesToRemove = new Dictionary<PSModuleInfo, List<PSModuleInfo>>();
// We want to remove the modules starting from the nested modules
// If we start from the parent module, the nested modules do not get removed and are left hanging in the parent modules's sessionstate.
// If we start from the parent module, the nested modules do not get removed and are left orphaned in the parent modules's sessionstate.
foreach (var entry in modulesToRemove)
{
List<PSModuleInfo> moduleList = new List<PSModuleInfo>();
@@ -3403,7 +3403,7 @@ namespace System.Management.Automation
(command.Commands[0].CommandText.IndexOf(".EnterNestedPrompt()", StringComparison.OrdinalIgnoreCase) > 0))
{
// Prevent a host EnterNestedPrompt() call from occuring in an active debugger.
// Host nested prompt makes no sense in this case and can cause hangs depending on host implementation.
// Host nested prompt makes no sense in this case and can cause host to stop responding depending on host implementation.
throw new PSNotSupportedException();
}
@@ -3283,7 +3283,7 @@ namespace System.Management.Automation
BatchInvocationContext context = new BatchInvocationContext(ExtraCommands[i], objs);
// Queue a batch work item here.
// Calling CoreInvokeAsync / CoreInvoke here directly doesn't work and causes the thread to hang.
// Calling CoreInvokeAsync / CoreInvoke here directly doesn't work and causes the thread to not respond.
ThreadPool.QueueUserWorkItem(new WaitCallback(BatchInvocationWorkItem), context);
context.Wait();
}
@@ -4037,7 +4037,7 @@ namespace System.Management.Automation
// This object can be disconnected even if "BeginStop" was called if it is a remote object
// and robust connections is retrying a failed network connection.
// In this case release the stop wait handle to prevent hangs.
// In this case release the stop wait handle to prevent not responding.
if (tempStopAsyncResult != null)
{
tempStopAsyncResult.SetAsCompleted(null);
@@ -767,7 +767,7 @@ namespace System.Management.Automation
_tracer.WriteMessage(TraceClassName, "StartJob", Guid.Empty, this, "Entering method", null);
s_structuredTracer.BeginContainerParentJobExecution(InstanceId);
// If parent contains no child jobs then this method will hang. Throw error in this case.
// If parent contains no child jobs then this method will not respond. Throw error in this case.
if (ChildJobs.Count == 0)
{
throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs);
@@ -951,7 +951,7 @@ namespace System.Management.Automation
AssertNotDisposed();
_tracer.WriteMessage(TraceClassName, "ResumeJob", Guid.Empty, this, "Entering method", null);
// If parent contains no child jobs then this method will hang. Throw error in this case.
// If parent contains no child jobs then this method will not respond. Throw error in this case.
if (ChildJobs.Count == 0)
{
throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs);
@@ -1188,7 +1188,7 @@ namespace System.Management.Automation
AssertNotDisposed();
_tracer.WriteMessage(TraceClassName, "UnblockJob", Guid.Empty, this, "Entering method", null);
// If parent contains no child jobs then this method will hang. Throw error in this case.
// If parent contains no child jobs then this method will not respond. Throw error in this case.
if (ChildJobs.Count == 0)
{
throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs);
@@ -1353,7 +1353,7 @@ namespace System.Management.Automation
AssertNotDisposed();
_tracer.WriteMessage(TraceClassName, "SuspendJob", Guid.Empty, this, "Entering method", null);
// If parent contains no child jobs then this method will hang. Throw error in this case.
// If parent contains no child jobs then this method will not respond. Throw error in this case.
if (ChildJobs.Count == 0)
{
throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs);
@@ -1526,7 +1526,7 @@ namespace System.Management.Automation
AssertNotDisposed();
_tracer.WriteMessage(TraceClassName, "StopJob", Guid.Empty, this, "Entering method", null);
// If parent contains no child jobs then this method will hang. Throw error in this case.
// If parent contains no child jobs then this method will not respond. Throw error in this case.
if (ChildJobs.Count == 0)
{
throw PSTraceSource.NewInvalidOperationException(RemotingErrorIdStrings.JobActionInvalidWithNoChildJobs);
@@ -125,7 +125,7 @@ namespace System.Management.Automation.Remoting
private void HandleFatalError(Exception ex)
{
// Event handlers should not throw exceptions. But if they do we need to
// handle them here to prevent the state machine from hanging when there are pending
// handle them here to prevent the state machine from not responding when there are pending
// events to process.
// Enqueue a fatal error event if such an exception occurs; clear all existing events.. we are going to terminate the session
@@ -794,7 +794,7 @@ namespace Microsoft.PowerShell.Commands
var hostDebugger = GetHostDebugger();
if (hostDebugger == null)
{
// Do not allow RemoteDebug if there is no host debugger available. Otherwise script will hang indefinitely.
// Do not allow RemoteDebug if there is no host debugger available. Otherwise script will not respond indefinitely.
RemoteDebug = false;
}
else if (hostDebugger.IsDebuggerSteppingEnabled)
@@ -939,7 +939,7 @@ namespace Microsoft.PowerShell.Commands
{
// Use remote steppable pipeline only for non-input piping case.
// Win8 Bug:898011 - We are restricting remote steppable pipeline because
// of this bug in Win8 where hangs can occur during data piping.
// of this bug in Win8 where not responding can occur during data piping.
// We are reverting to Win7 behavior for {icm | icm} and {proxycommand | proxycommand}
// cases. For ICM | % ICM case, we are using remote steppable pipeline.
if ((MyInvocation != null) && (MyInvocation.PipelinePosition == 1) && (MyInvocation.ExpectingInput == false))
@@ -240,7 +240,7 @@ namespace System.Management.Automation.Remoting
/// (close runspace or stop powershell). For instance, when the user hits ctrl-C,
/// New-PSSession cmdlet tries to call a stop on all remote runspaces which are in the Opening state.
/// The user wouldn't mind waiting for 15 seconds, but this should be time bound and of a shorter duration.
/// A high timeout here like 3 minutes will give the user a feeling that the PowerShell client has hung.
/// A high timeout here like 3 minutes will give the user a feeling that the PowerShell client is not responding.
///
/// Default: 60 * 1000 = 1 minute
/// </summary>
@@ -392,7 +392,7 @@ namespace Microsoft.PowerShell.Commands
/// stop on all remote runspaces which are in the Opening state. The user
/// wouldn't mind waiting for 15 seconds, but this should be time bound and of a
/// shorter duration. A high timeout here like 3 minutes will give the user
/// a feeling that the PowerShell client has hung.
/// a feeling that the PowerShell client is not responding.
/// </summary>
[Parameter]
[Alias("CancelTimeoutMSec")]
@@ -3438,7 +3438,7 @@ namespace Microsoft.PowerShell.Commands
else
{
// raise an OperationComplete event here. Else the
// throttle manager will hang as it will be waiting for
// throttle manager will not respond as it will be waiting for
// this StopOperation to complete
RaiseOperationCompleteEvent();
}
@@ -1308,7 +1308,7 @@ namespace Microsoft.PowerShell.Commands
// callbacks for two reasons:
// a) To ensure callbacks are made in list order (first added, first called).
// b) To ensure all callbacks are fired by manually invoking callbacks and handling
// any exceptions thrown on this thread. (ThrottleManager will hang if it doesn't
// any exceptions thrown on this thread. (ThrottleManager will not respond if it doesn't
// get a start/stop complete callback).
private List<EventHandler<OperationStateEventArgs>> _internalCallbacks = new List<EventHandler<OperationStateEventArgs>>();
internal override event EventHandler<OperationStateEventArgs> OperationComplete
@@ -1401,7 +1401,7 @@ namespace Microsoft.PowerShell.Commands
}
foreach (var callbackDelegate in copyCallbacks)
{
// Ensure all callbacks get called to prevent ThrottleManager hang.
// Ensure all callbacks get called to prevent ThrottleManager from not responding.
try
{
callbackDelegate.SafeInvoke(this, operationStateEventArgs);
@@ -253,7 +253,7 @@ namespace System.Management.Automation.Runspaces
/// (close runspace or stop powershell). For instance, when the user hits ctrl-C,
/// New-PSSession cmdlet tries to call a stop on all remote runspaces which are in the Opening state.
/// The administrator wouldn't mind waiting for 15 seconds, but this should be time bound and of a shorter duration.
/// A high timeout here like 3 minutes will give the administrator a feeling that the PowerShell client has hung.
/// A high timeout here like 3 minutes will give the administrator a feeling that the PowerShell client is not responding.
/// </summary>
public int CancelTimeout { get; set; } = defaultCancelTimeout;
@@ -625,7 +625,7 @@ namespace System.Management.Automation.Remoting.Client
lock (syncObject)
{
// We always need to remove commands from collection, even if isClosed is true.
// If we don't then we hang because CloseAsync() will not complete until all
// If we don't then we will not respond because CloseAsync() will not complete until all
// commands are closed.
if (!_cmdTransportManagers.Remove(key))
{
@@ -206,7 +206,7 @@ namespace System.Management.Automation.Remoting.Server
}
finally
{
// Always send ack signal to avoid hang in client.
// Always send ack signal to avoid not responding in client.
originalStdOut.WriteLine(OutOfProcessUtils.CreateSignalAckPacket(psGuid));
}
}
@@ -389,7 +389,7 @@ namespace System.Management.Automation
{
// Since this is being invoked asynchronously on a single pipeline thread
// any invoke failures (such as possible debugger failures) need to be
// passed back to client or the original client invoke request will hang.
// passed back to client or the original client invoke request will not respond.
string failedCommand = LocalPowerShell.Commands.Commands[0].CommandText;
LocalPowerShell.Commands.Clear();
string msg = StringUtil.Format(
@@ -2458,7 +2458,7 @@ namespace System.Management.Automation
}
// Set debug mode to "None" so that current command can stop and not
// potentially hang in a debugger stop. Use RestoreDebugger() to
// potentially not respond in a debugger stop. Use RestoreDebugger() to
// restore debugger to original mode.
_wrappedDebugger.Value.SetDebugMode(DebugModes.None);
if (InBreakpoint)
@@ -98,7 +98,7 @@ namespace System.Management.Automation
// We need to catch this so that we can set the pipeline execution;
// state to "failed" and send the exception as an error to the user.
// Otherwise, the event manager will swallow this exception and
// cause the client to hang.
// cause the client to not respond.
exceptionOccurred = e;
}
+1 -1
View File
@@ -52,7 +52,7 @@ namespace TestPSReadLine
// This is a workaround to ensure the command analysis cache has been created before
// we enter into ReadLine. It's a little slow and infrequently needed, so just
// uncomment if you hit a hang, run it once, then comment it out again.
// uncomment host stops responding, run it once, then comment it out again.
//ps.Commands.Clear();
//ps.AddCommand("Get-Command").Invoke();
}
+1 -1
View File
@@ -284,7 +284,7 @@ Describe "ConsoleHost unit tests" -tags "Feature" {
Context "Input redirected but not reading from stdin (not really interactive)" {
# Tests under this context are testing that we do not read from StandardInput
# even though it is redirected - we want to make sure we don't hang.
# even though it is redirected - we want to make sure we don't stop responding.
# So none of these tests should close StandardInput
It "Redirected input w/ implicit -Command w/ -NonInteractive" {
@@ -27,7 +27,7 @@ Describe "Invoke-Item basic tests" -Tags "Feature" {
}
## Run this test only on macOS because redirecting stderr of 'xdg-open' results in weird behavior in our Linux CI,
## causing this test to fail or the build to hang.
## causing this test to fail or the build to not respond.
It "Should invoke text file '<TestFile>' without error on Mac" -Skip:(!$IsMacOS) -TestCases $textFileTestCases {
param($TestFile)
@@ -239,7 +239,7 @@ Describe "Get-Help should find help info within help files" -Tags @('CI', 'Requi
Describe "Get-Help should find pattern help files" -Tags "CI" {
# There is a bug specific to Travis CI that hangs the test if "get-help" is used to search pattern string. This doesn't repro locally.
# There is a bug specific to Travis CI that suspends the test if "get-help" is used to search pattern string. This doesn't repro locally.
# This occurs even if Unix system just returns "Directory.GetFiles(path, pattern);" as the windows' code does.
# Since there's currently no way to get the vm from Travis CI and the test PASSES locally on both Ubuntu and MacOS, excluding pattern test under Unix system.