admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

mruby-task: fix validation bugs in task creation

Browse Source 
fix uninitialized kwargs array causing crashes, add type validation for
name (must be String) and priority (must be Integer) parameters, return
"(noname)" for unnamed tasks.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Yukihiro "Matz" Matsumoto
2025-10-11 08:43:16 +09:00
parent 2a124a704f
commit dd06920640
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mrbgems/mruby-task/src/task.c
+16 -3
View File
@@ -989,7 +989,7 @@ mrb_task_s_new(mrb_state *mrb, mrb_value self)
const struct RProc *proc;
mrb_task *t;
mrb_value task_obj;
mrb_value kw_values[2];
mrb_value kw_values[2] = {mrb_undef_value(), mrb_undef_value()};
const mrb_kwargs kwargs = {
2, 0, (mrb_sym[]){mrb_intern_lit(mrb, "name"), mrb_intern_lit(mrb, "priority")}, kw_values, NULL
};
@@ -1004,10 +1004,18 @@ mrb_task_s_new(mrb_state *mrb, mrb_value self)
proc = mrb_proc_ptr(blk);
/* Parse keyword arguments */
if (!mrb_nil_p(kw_values[0])) {
if (!mrb_undef_p(kw_values[0])) {
/* Validate name type - must be String */
if (!mrb_string_p(kw_values[0])) {
mrb_raise(mrb, E_TYPE_ERROR, "name must be a String");
}
name_val = kw_values[0];
}
if (!mrb_nil_p(kw_values[1])) {
if (!mrb_undef_p(kw_values[1])) {
/* Validate priority type - must be Integer */
if (!mrb_integer_p(kw_values[1])) {
mrb_raise(mrb, E_TYPE_ERROR, "priority must be an Integer");
}
priority = mrb_integer(kw_values[1]);
if (priority < 0 || priority > 255) {
mrb_raise(mrb, E_ARGUMENT_ERROR, "priority must be 0-255");
@@ -1298,6 +1306,11 @@ mrb_task_name(mrb_state *mrb, mrb_value self)
TASK_GET_PTR_OR_RAISE(t, self);
/* Return "(noname)" if name is not set */
if (mrb_nil_p(t->name)) {
return mrb_str_new_lit(mrb, "(noname)");
}
return t->name;
}