mirror of
https://github.com/wshobson/agents
synced 2026-06-21 14:13:58 +00:00
review: address PR #550 review feedback — revert bot-driven changes to test and base adapter
- Delete agents_skills.txt and gemini_skills.txt (stale lint outputs) - Remove agents/*.agent.md gitignore guard - README.md: restore original table header, Claude Code row, simplify generate-all comment - docs/authoring.md: re-add Codex deprecated note alongside Copilot info - docs/usage.md: restore removed pr-enhance command - tools/adapters/base.py: remove AskUserQuestion mapping - tools/tests/test_cli_smoke.py: revert TTY skip in codex doctor test
This commit is contained in:
+1
-2
@@ -50,5 +50,4 @@ commands/**/*.toml
|
||||
/commands/
|
||||
/agents/
|
||||
/skills/
|
||||
# Guard Gemini output from pollution (generated .agent.md files in root agents/)
|
||||
agents/*.agent.md
|
||||
|
||||
|
||||
@@ -76,9 +76,9 @@ Three-tier model strategy:
|
||||
This marketplace ships to five agentic harnesses from one Markdown source. Each adapter
|
||||
emits harness-native artifacts (not lowest-common-denominator translations):
|
||||
|
||||
| Harness | Output path | Notes |
|
||||
| Harness | Generates | Notes |
|
||||
|---|---|---|
|
||||
| **Claude Code** | `plugins/` (source-of-truth) | Native `marketplace.json` + per-plugin `plugin.json` |
|
||||
| **Claude Code** | (source-of-truth) | Native `marketplace.json` + `plugins/` |
|
||||
| **Codex CLI** | `.codex/skills/`, `.codex/agents/` | 8 KB skill cap respected; commands → skills |
|
||||
| **Cursor** | `.cursor-plugin/`, `.cursor/rules/` | Thin marketplace + curated rules; reuses `.claude/` |
|
||||
| **OpenCode** | `.opencode/agents/`, `.opencode/commands/`, `.opencode/skills/` | `permission:` block from `tools:` allowlist; OpenCode-safe skill names |
|
||||
@@ -86,7 +86,7 @@ emits harness-native artifacts (not lowest-common-denominator translations):
|
||||
| **Copilot** | `.copilot/agents/`, `.copilot/skills/` | Markdown agent profiles + SKILL.md skills; model maps to GPT-5 family |
|
||||
|
||||
```bash
|
||||
make generate-all # all 5 generated harnesses (claude-code is source, not generated)
|
||||
make generate-all # all five
|
||||
make validate # structural checks
|
||||
make garden # drift / dead-link / cap detection
|
||||
```
|
||||
|
||||
@@ -1,28 +0,0 @@
|
||||
aposd
|
||||
aposd-audit
|
||||
aposd-critique
|
||||
brainstorming
|
||||
dispatching-parallel-agents
|
||||
enhance-prompt
|
||||
executing-plans
|
||||
find-skills
|
||||
finishing-a-development-branch
|
||||
gh-cli
|
||||
git-commit
|
||||
impeccable
|
||||
karpathy-guidelines
|
||||
react-components
|
||||
receiving-code-review
|
||||
repo-roast
|
||||
requesting-code-review
|
||||
shadcn-ui
|
||||
stitch-design
|
||||
stitch-loop
|
||||
subagent-driven-development
|
||||
systematic-debugging
|
||||
test-driven-development
|
||||
using-git-worktrees
|
||||
using-superpowers
|
||||
verification-before-completion
|
||||
writing-plans
|
||||
writing-skills
|
||||
+1
-1
@@ -26,7 +26,7 @@ do, and what to avoid, so the work you do for Claude Code translates cleanly eve
|
||||
|---|---|---|---|
|
||||
| `agents/<name>.md` | `name`, `description` | `model`, optional `tools:`, optional `color:` | `tools:` allowlist becomes a per-harness permission block where supported, dropped otherwise. |
|
||||
| `skills/<name>/SKILL.md` | `name`, `description` | (none) | Other Anthropic SKILL.md fields work on Claude Code only. |
|
||||
| `commands/<name>.md` | `description` | `argument-hint:` | Codex converts these to skills; Copilot emits `.copilot/commands/<plugin>/<name>.md` slash-command prompts. |
|
||||
| `commands/<name>.md` | `description` | `argument-hint:` | Codex converts these to skills (it deprecated `~/.codex/prompts/`). Copilot emits `.copilot/commands/<plugin>/<name>.md` slash-command prompts. |
|
||||
|
||||
**Description triggers.** Include a recognized phrase: `Use when …`, `Use this skill when …`,
|
||||
`Use PROACTIVELY when …`, `Use after …`, `Trigger when …`, `Auto-loads when …`. The
|
||||
|
||||
+2
-1
@@ -70,7 +70,8 @@ Claude Code automatically selects and coordinates the appropriate agents based o
|
||||
|
||||
| Command | Description |
|
||||
| ----------------------------------- | -------------------------- |
|
||||
| `/comprehensive-review:full-review` | Run the comprehensive review workflow |
|
||||
| `/comprehensive-review:full-review` | Multi-perspective analysis |
|
||||
| `/comprehensive-review:pr-enhance` | Enhance pull requests |
|
||||
|
||||
### Debugging & Troubleshooting
|
||||
|
||||
|
||||
@@ -1,14 +0,0 @@
|
||||
brainstorming
|
||||
dispatching-parallel-agents
|
||||
executing-plans
|
||||
finishing-a-development-branch
|
||||
receiving-code-review
|
||||
requesting-code-review
|
||||
subagent-driven-development
|
||||
systematic-debugging
|
||||
test-driven-development
|
||||
using-git-worktrees
|
||||
using-superpowers
|
||||
verification-before-completion
|
||||
writing-plans
|
||||
writing-skills
|
||||
@@ -466,7 +466,6 @@ class HarnessAdapter(ABC):
|
||||
"WebFetch": "fetch",
|
||||
"WebSearch": "search",
|
||||
"TodoWrite": "todo",
|
||||
"AskUserQuestion": "question",
|
||||
}
|
||||
out = body
|
||||
for camel, replacement in replacements.items():
|
||||
|
||||
@@ -128,19 +128,10 @@ class TestCodexSmoke:
|
||||
a battery of structural checks and surfaces drift in the local install."""
|
||||
proc = _run(["codex", "doctor"])
|
||||
# Codex doctor returns 0 on healthy install; warnings are inline but don't fail.
|
||||
if proc.returncode != 0:
|
||||
# Some environments (CI containers) cannot provide a TTY; Codex doctor
|
||||
# emits "stdin is not a terminal" in stderr and returns 1. Treat that as
|
||||
# an environment limitation and skip the test rather than failing the PR.
|
||||
if proc.stderr and "stdin is not a terminal" in proc.stderr:
|
||||
pytest.skip(
|
||||
f"codex doctor not runnable in non-interactive env: {proc.stderr.strip()}"
|
||||
)
|
||||
# Otherwise, a real failure — surface it.
|
||||
assert proc.returncode == 0, (
|
||||
f"codex doctor failed (rc={proc.returncode}):\n"
|
||||
f"--- stdout ---\n{proc.stdout[:2000]}\n--- stderr ---\n{proc.stderr}"
|
||||
)
|
||||
assert proc.returncode == 0, (
|
||||
f"codex doctor failed (rc={proc.returncode}):\n"
|
||||
f"--- stdout ---\n{proc.stdout[:2000]}\n--- stderr ---\n{proc.stderr}"
|
||||
)
|
||||
|
||||
@pytest.mark.skipif(
|
||||
not (WORKTREE / ".codex").is_dir(),
|
||||
|
||||
Reference in New Issue
Block a user